From a42aa048265725d4dda2333a1656b19d52f5435e Mon Sep 17 00:00:00 2001 From: Justin McCandless Date: Mon, 14 Dec 2020 10:26:52 -0800 Subject: [PATCH] Remove duplicate setState in TextFormFieldState.reset (#69062) Small performance optimization by removing a duplicate setState call. --- packages/flutter/lib/src/material/text_form_field.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/flutter/lib/src/material/text_form_field.dart b/packages/flutter/lib/src/material/text_form_field.dart index dd77378afd..f17bbac7de 100644 --- a/packages/flutter/lib/src/material/text_form_field.dart +++ b/packages/flutter/lib/src/material/text_form_field.dart @@ -359,10 +359,10 @@ class _TextFormFieldState extends FormFieldState { @override void reset() { + // setState will be called in the superclass, so even though state is being + // manipulated, no setState call is needed here. + _effectiveController!.text = widget.initialValue ?? ''; super.reset(); - setState(() { - _effectiveController!.text = widget.initialValue ?? ''; - }); } void _handleControllerChanged() {