firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename Border.uniform() -> Border.fromSide() (#30792)

Browse Source
This commit is contained in:
Todd Volkert 2019-04-17 10:58:42 -07:00 committed by GitHub
parent efe744a360
commit a4ab0321ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/painting/box_border.dart
View File

@ -317,7 +317,7 @@ class Border extends BoxBorder {
/// Creates a border whose sides are all the same. /// Creates a border whose sides are all the same.
/// ///
/// The `side` argument must not be null. /// The `side` argument must not be null.
const Border.uniform(BorderSide side) const Border.fromBorderSide(BorderSide side)
: assert(side != null), : assert(side != null),
top = side, top = side,
right = side, right = side,
@ -333,7 +333,7 @@ class Border extends BoxBorder {
BorderStyle style = BorderStyle.solid, BorderStyle style = BorderStyle.solid,
}) { }) {
final BorderSide side = BorderSide(color: color, width: width, style: style); final BorderSide side = BorderSide(color: color, width: width, style: style);
return Border.uniform(side); return Border.fromBorderSide(side);
} }
/// Creates a [Border] that represents the addition of the two given /// Creates a [Border] that represents the addition of the two given

4
packages/flutter/test/painting/border_test.dart
View File

@ -14,9 +14,9 @@ void main() {
}); });
test('Border.uniform constructor', () { test('Border.uniform constructor', () {
expect(() => Border.uniform(null), throwsAssertionError); expect(() => Border.fromBorderSide(null), throwsAssertionError);
const BorderSide side = BorderSide(); const BorderSide side = BorderSide();
const Border border = Border.uniform(side); const Border border = Border.fromBorderSide(side);
expect(border.left, same(side)); expect(border.left, same(side));
expect(border.top, same(side)); expect(border.top, same(side));
expect(border.right, same(side)); expect(border.right, same(side));