From a5b9b5774aa5eedb8e4944a090e9c65e3de29266 Mon Sep 17 00:00:00 2001 From: keyonghan <54558023+keyonghan@users.noreply.github.com> Date: Mon, 19 Jul 2021 20:23:45 -0700 Subject: [PATCH] Fix the tree (#86691) * fix type cast error * update doc --- dev/devicelab/lib/command/upload_results.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dev/devicelab/lib/command/upload_results.dart b/dev/devicelab/lib/command/upload_results.dart index f1a9e22478..7bc2d95af3 100644 --- a/dev/devicelab/lib/command/upload_results.dart +++ b/dev/devicelab/lib/command/upload_results.dart @@ -13,7 +13,7 @@ class UploadResultsCommand extends Command { 'service-account-token-file', help: 'Authentication token for uploading results.', ); - argParser.addOption('test-flaky', help: 'Flag to show whether the test is flaky'); + argParser.addOption('test-flaky', help: 'Flag to show whether the test is flaky: "True" or "False"'); argParser.addOption( 'git-branch', help: '[Flutter infrastructure] Git branch of the current commit. LUCI\n' @@ -33,7 +33,7 @@ class UploadResultsCommand extends Command { Future run() async { final String? resultsPath = argResults!['results-file'] as String?; final String? serviceAccountTokenFile = argResults!['service-account-token-file'] as String?; - final bool? isTestFlaky = argResults!['test-flaky'] as bool?; + final String? testFlakyStatus = argResults!['test-flaky'] as String?; final String? gitBranch = argResults!['git-branch'] as String?; final String? builderName = argResults!['luci-builder'] as String?; final String? testStatus = argResults!['test-status'] as String?; @@ -41,7 +41,7 @@ class UploadResultsCommand extends Command { final Cocoon cocoon = Cocoon(serviceAccountTokenPath: serviceAccountTokenFile); return cocoon.sendResultsPath( resultsPath: resultsPath, - isTestFlaky: isTestFlaky, + isTestFlaky: testFlakyStatus == 'True', gitBranch: gitBranch, builderName: builderName, testStatus: testStatus,