firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RenderObject.flushLayout should loop until _nodesNeedingLayout is empty

Browse Source
This commit is contained in:
Hans Muller 2015-08-24 12:41:27 -07:00
parent 9a493c15e9
commit a61f0f5021
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/rendering/object.dart
View File

@ -407,12 +407,15 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
sky.tracing.begin('RenderObject.flushLayout'); sky.tracing.begin('RenderObject.flushLayout');
_debugDoingLayout = true; _debugDoingLayout = true;
try { try {
// TODO(ianh): assert that we're not allowing previously dirty nodes to redirty themeselves
while(_nodesNeedingLayout.isNotEmpty) {
List<RenderObject> dirtyNodes = _nodesNeedingLayout; List<RenderObject> dirtyNodes = _nodesNeedingLayout;
_nodesNeedingLayout = new List<RenderObject>(); _nodesNeedingLayout = new List<RenderObject>();
dirtyNodes..sort((a, b) => a.depth - b.depth)..forEach((node) { dirtyNodes..sort((a, b) => a.depth - b.depth)..forEach((node) {
if (node._needsLayout && node.attached) if (node._needsLayout && node.attached)
node.layoutWithoutResize(); node.layoutWithoutResize();
}); });
}
} finally { } finally {
_debugDoingLayout = false; _debugDoingLayout = false;
sky.tracing.end('RenderObject.flushLayout'); sky.tracing.end('RenderObject.flushLayout');