From a657428b5c07ea015dbb0de478cbb1dbde45feb3 Mon Sep 17 00:00:00 2001
From: Jason Simmons <jason-simmons@users.noreply.github.com>
Date: Wed, 19 Apr 2017 16:04:47 -0700
Subject: [PATCH] Capture didExceedMaxLines after doing text layout with
 constraints (#9457)

Subsequent operations like debugAssertDoesMeetConstraints() may do layout
operations that alter _textPainter's state.

Fixes https://github.com/flutter/flutter/issues/9372
---
 packages/flutter/lib/src/rendering/paragraph.dart   | 7 ++++++-
 packages/flutter/test/rendering/paragraph_test.dart | 8 ++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/packages/flutter/lib/src/rendering/paragraph.dart b/packages/flutter/lib/src/rendering/paragraph.dart
index 26507156a2..7cd9eb65d0 100644
--- a/packages/flutter/lib/src/rendering/paragraph.dart
+++ b/packages/flutter/lib/src/rendering/paragraph.dart
@@ -6,6 +6,7 @@ import 'dart:ui' as ui;
 
 import 'package:flutter/gestures.dart';
 import 'package:flutter/services.dart';
+import 'package:meta/meta.dart';
 
 import 'box.dart';
 import 'debug.dart';
@@ -189,17 +190,21 @@ class RenderParagraph extends RenderBox {
   bool _hasVisualOverflow = false;
   ui.Shader _overflowShader;
 
+  @visibleForTesting
+  bool get debugHasOverflowShader => _overflowShader != null;
+
   @override
   void performLayout() {
     _layoutTextWithConstraints(constraints);
     // We grab _textPainter.size here because assigning to `size` will trigger
     // us to validate our intrinsic sizes, which will change _textPainter's
     // layout because the intrinsic size calculations are destructive.
+    // Other _textPainter state like didExceedMaxLines will also be affected.
     final Size textSize = _textPainter.size;
+    final bool didOverflowHeight = _textPainter.didExceedMaxLines;
     size = constraints.constrain(textSize);
 
     final bool didOverflowWidth = size.width < textSize.width;
-    final bool didOverflowHeight = _textPainter.didExceedMaxLines;
     // TODO(abarth): We're only measuring the sizes of the line boxes here. If
     // the glyphs draw outside the line boxes, we might think that there isn't
     // visual overflow when there actually is visual overflow. This can become
diff --git a/packages/flutter/test/rendering/paragraph_test.dart b/packages/flutter/test/rendering/paragraph_test.dart
index 99f19dcdfe..081e11c60b 100644
--- a/packages/flutter/test/rendering/paragraph_test.dart
+++ b/packages/flutter/test/rendering/paragraph_test.dart
@@ -135,5 +135,13 @@ void main() {
 
     relayoutWith(maxLines: null, softWrap: false, overflow: TextOverflow.ellipsis);
     expect(paragraph.size.height, equals(2 * lineHeight));
+
+    // Test presence of the fade effect.
+    relayoutWith(maxLines: 3, softWrap: true, overflow: TextOverflow.fade);
+    expect(paragraph.debugHasOverflowShader, isTrue);
+
+    relayoutWith(maxLines: 100, softWrap: true, overflow: TextOverflow.fade);
+    expect(paragraph.debugHasOverflowShader, isFalse);
   });
 }
+