firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Devicelab run.dart: Fixed check for path equality (#41403)

Browse Source 
Fixed check for path equality.  It was too strict, disallowing leading "./".
This commit is contained in:
gaaclarke 2019-09-26 17:09:05 -07:00 committed by GitHub
parent efd2ba296b
commit a66ea4f21b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dev/devicelab/bin/run.dart
View File

@ -123,7 +123,7 @@ final ArgParser _argParser = ArgParser()
if (fragments.length == 1 && !isDartFile) { if (fragments.length == 1 && !isDartFile) {
// Not a path // Not a path
_taskNames.add(nameOrPath); _taskNames.add(nameOrPath);
} else if (!isDartFile || fragments.length != 3 || !_listsEqual(<String>['bin', 'tasks'], fragments.take(2).toList())) { } else if (!isDartFile || !path.equals(path.dirname(nameOrPath), path.join('bin', 'tasks'))) {
// Unsupported executable location // Unsupported executable location
throw FormatException('Invalid value for option -t (--task): $nameOrPath'); throw FormatException('Invalid value for option -t (--task): $nameOrPath');
} else { } else {
@ -197,15 +197,3 @@ final ArgParser _argParser = ArgParser()
} }
}, },
); );
bool _listsEqual(List<dynamic> a, List<dynamic> b) {
if (a.length != b.length)
return false;
for (int i = 0; i < a.length; i++) {
if (a[i] != b[i])
return false;
}
return true;
}