firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1693 from jimbeveridge/close

Browse Source 
Close the UrlLoaderProxy on error.
This commit is contained in:
Jim Beveridge 2015-10-20 10:43:18 -07:00
commit a6c1018521
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/flutter/lib/src/services/fetch.dart
View File

@ -36,24 +36,25 @@ class Response {
} }
Future<UrlResponse> fetch(UrlRequest request) async { Future<UrlResponse> fetch(UrlRequest request) async {
UrlLoaderProxy loader = new UrlLoaderProxy.unbound();
try { try {
UrlLoaderProxy loader = new UrlLoaderProxy.unbound();
_networkService.ptr.createUrlLoader(loader); _networkService.ptr.createUrlLoader(loader);
UrlResponse response = (await loader.ptr.start(request)).response; UrlResponse response = (await loader.ptr.start(request)).response;
loader.close();
return response; return response;
} catch (e) { } catch (e) {
print("NetworkService unavailable $e"); print("NetworkService unavailable $e");
return new UrlResponse()..statusCode = 500; return new UrlResponse()..statusCode = 500;
} finally {
loader.close();
} }
} }
Future<UrlResponse> fetchUrl(String relativeUrl) async { Future<UrlResponse> fetchUrl(String relativeUrl) {
String url = Uri.base.resolve(relativeUrl).toString(); String url = Uri.base.resolve(relativeUrl).toString();
UrlRequest request = new UrlRequest() UrlRequest request = new UrlRequest()
..url = url ..url = url
..autoFollowRedirects = true; ..autoFollowRedirects = true;
return await fetch(request); return fetch(request);
} }
Future<Response> fetchBody(String relativeUrl) async { Future<Response> fetchBody(String relativeUrl) async {