firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix gen_snapshot name, path for Windows.

Browse Source 
Executables have '.exe' extension on Windows. We do have to specify extension for gen_snapshot since when running with local engine, we are looking for that exact file before launching it.
This commit is contained in:
Alexander Aprelev 2017-12-22 14:39:13 -08:00
parent 31e78f1e7f
commit a6c963032e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/artifacts.dart
View File

@ -33,7 +33,7 @@ String _artifactToFileName(Artifact artifact) {
case Artifact.dartVmEntryPointsTxt: case Artifact.dartVmEntryPointsTxt:
return 'dart_vm_entry_points.txt'; return 'dart_vm_entry_points.txt';
case Artifact.genSnapshot: case Artifact.genSnapshot:
return 'gen_snapshot'; return platform.isWindows ? 'gen_snapshot.exe' : 'gen_snapshot';
case Artifact.flutterTester: case Artifact.flutterTester:
return 'flutter_tester'; return 'flutter_tester';
case Artifact.snapshotDart: case Artifact.snapshotDart:
@ -262,7 +262,7 @@ class LocalEngineArtifacts extends Artifacts {
} }
String _genSnapshotPath() { String _genSnapshotPath() {
const List<String> clangDirs = const <String>['clang_x86', 'clang_x64', 'clang_i386']; const List<String> clangDirs = const <String>['.', 'clang_x86', 'clang_x64', 'clang_i386'];
final String genSnapshotName = _artifactToFileName(Artifact.genSnapshot); final String genSnapshotName = _artifactToFileName(Artifact.genSnapshot);
for (String clangDir in clangDirs) { for (String clangDir in clangDirs) {
final String genSnapshotPath = fs.path.join(engineOutPath, clangDir, genSnapshotName); final String genSnapshotPath = fs.path.join(engineOutPath, clangDir, genSnapshotName);