From a7c6cc19a39b92329d34266a63796d663656f80d Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Wed, 12 Feb 2025 17:00:07 -0800 Subject: [PATCH] [flutter_tools] remove SkSL target for iOS builds. (#163144) Skia is no longer supported on iOS targets, so runtime shaders don't need to bundle SkSL. Fixes https://github.com/flutter/flutter/issues/138919 --- .../lib/src/build_system/tools/shader_compiler.dart | 1 + .../test/general.shard/build_system/targets/ios_test.dart | 1 - .../general.shard/build_system/targets/shader_compiler_test.dart | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/flutter_tools/lib/src/build_system/tools/shader_compiler.dart b/packages/flutter_tools/lib/src/build_system/tools/shader_compiler.dart index 2b6f193854..af85ca60a2 100644 --- a/packages/flutter_tools/lib/src/build_system/tools/shader_compiler.dart +++ b/packages/flutter_tools/lib/src/build_system/tools/shader_compiler.dart @@ -123,6 +123,7 @@ class ShaderCompiler { ]; case TargetPlatform.ios: + return ['--runtime-stage-metal']; case TargetPlatform.darwin: return ['--sksl', '--runtime-stage-metal']; diff --git a/packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart b/packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart index 296b3a3fb3..704b9effd6 100644 --- a/packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart +++ b/packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart @@ -314,7 +314,6 @@ void main() { const FakeCommand( command: [ 'HostArtifact.impellerc', - '--sksl', '--runtime-stage-metal', '--iplr', '--sl=/App.framework/flutter_assets/shader.glsl', diff --git a/packages/flutter_tools/test/general.shard/build_system/targets/shader_compiler_test.dart b/packages/flutter_tools/test/general.shard/build_system/targets/shader_compiler_test.dart index a9080ea09d..c225aa3b27 100644 --- a/packages/flutter_tools/test/general.shard/build_system/targets/shader_compiler_test.dart +++ b/packages/flutter_tools/test/general.shard/build_system/targets/shader_compiler_test.dart @@ -86,7 +86,6 @@ void main() { FakeCommand( command: [ impellerc, - '--sksl', '--runtime-stage-metal', '--iplr', '--sl=$outputPath',