firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PageView shouldn't crash in zero-size container (#8282)

Browse Source 
Previously, we were dividing by zero.

Fixes #8281
This commit is contained in:
Adam Barth 2017-02-18 13:38:56 -08:00 committed by GitHub
parent 257be181fd
commit a8e847aba9
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/rendering/sliver_fixed_extent_list.dart
View File

@ -37,8 +37,8 @@ abstract class RenderSliverFixedExtentBoxAdaptor extends RenderSliverMultiBoxAda
maxExtent: itemExtent, maxExtent: itemExtent,
); );
final int firstIndex = math.max(0, scrollOffset ~/ itemExtent); final int firstIndex = itemExtent > 0.0 ? math.max(0, scrollOffset ~/ itemExtent) : 0;
final int targetLastIndex = math.max(0, (targetEndScrollOffset / itemExtent).ceil() - 1); final int targetLastIndex = itemExtent > 0.0 ? math.max(0, (targetEndScrollOffset / itemExtent).ceil() - 1) : 0;
if (firstChild != null) { if (firstChild != null) {
final int oldFirstIndex = indexOf(firstChild); final int oldFirstIndex = indexOf(firstChild);

14
packages/flutter/test/widgets/page_view_test.dart
View File

@ -191,4 +191,18 @@ void main() {
expect(find.text('Arizona'), findsOneWidget); expect(find.text('Arizona'), findsOneWidget);
}); });
testWidgets('PageView in zero-size container', (WidgetTester tester) async {
await tester.pumpWidget(new Center(
child: new SizedBox(
width: 0.0,
height: 0.0,
child: new PageView(
children: kStates.map<Widget>((String state) => new Text(state)).toList(),
),
),
));
expect(find.text('Alabama'), findsOneWidget);
});
} }