From a9151779aa0848e9c976e5d27b247b47b7a18823 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 8 Aug 2019 18:15:40 -0700 Subject: [PATCH] Revert "Add equals and hasCode to Tween (#37793)" (#37895) This reverts commit b39e315e5cb9a9c51ebdf3242a108084378a1d9b. --- packages/flutter/lib/src/animation/tween.dart | 17 +---------------- packages/flutter/test/animation/tween_test.dart | 14 -------------- 2 files changed, 1 insertion(+), 30 deletions(-) diff --git a/packages/flutter/lib/src/animation/tween.dart b/packages/flutter/lib/src/animation/tween.dart index 20cd9c42a3..82401c1bb2 100644 --- a/packages/flutter/lib/src/animation/tween.dart +++ b/packages/flutter/lib/src/animation/tween.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'dart:ui' show Color, Rect, Size, hashValues; +import 'dart:ui' show Color, Size, Rect; import 'package:flutter/foundation.dart'; @@ -260,21 +260,6 @@ class Tween extends Animatable { return lerp(t); } - @override - int get hashCode { - return hashValues(begin, end); - } - - @override - bool operator ==(dynamic other) { - if (identical(this, other)) - return true; - if (other.runtimeType != runtimeType) - return false; - final Tween typedOther = other; - return typedOther.begin == begin && typedOther.end == end; - } - @override String toString() => '$runtimeType($begin \u2192 $end)'; } diff --git a/packages/flutter/test/animation/tween_test.dart b/packages/flutter/test/animation/tween_test.dart index 3ea5592cee..a0aedecd5e 100644 --- a/packages/flutter/test/animation/tween_test.dart +++ b/packages/flutter/test/animation/tween_test.dart @@ -93,18 +93,4 @@ void main() { expect(tween.lerp(0.5), 100.0); expect(tween.lerp(1.0), 100.0); }); - - test('Tween equals', () { - final Tween doubleTween1 = Tween(begin: 10, end: 22); - final Tween doubleTween2 = Tween(begin: 10, end: 22); - final Tween doubleTween3 = Tween(begin: 33, end: 44); - final Tween intTween = Tween(begin: 33, end: 44); - final Tween constantTween = ConstantTween(10); - - expect(doubleTween1 == doubleTween1, isTrue); - expect(doubleTween1 == doubleTween2, isTrue); - expect(doubleTween2 == doubleTween3, isFalse); - expect(doubleTween2 == intTween, isFalse); - expect(doubleTween1 == constantTween, isFalse); - }); }