firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure user-thrown errors have ErrorSummary nodes (#36857)

Browse Source
This commit is contained in:
Danny Tuppeny 2019-08-05 18:10:31 +01:00 committed by GitHub
parent 7c27142e58
commit aa9ca8fc5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/foundation/assertions.dart
View File

@ -411,7 +411,7 @@ class FlutterErrorDetails extends Diagnosticable {
String message = exceptionAsString(); String message = exceptionAsString();
if (message.startsWith(prefix)) if (message.startsWith(prefix))
message = message.substring(prefix.length); message = message.substring(prefix.length);
properties.add(ErrorDescription('$message')); properties.add(ErrorSummary('$message'));
} }
} }

24
packages/flutter/test/foundation/assertions_test.dart
View File

@ -328,4 +328,28 @@ void main() {
); );
} }
}); });
test('User-thrown exceptions have ErrorSummary properties', () {
{
DiagnosticsNode node;
try {
throw 'User thrown string';
} catch (e) {
node = FlutterErrorDetails(exception: e).toDiagnosticsNode();
}
final ErrorSummary summary = node.getProperties().whereType<ErrorSummary>().single;
expect(summary.value, equals(<String>['User thrown string']));
}
{
DiagnosticsNode node;
try {
throw ArgumentError.notNull('myArgument');
} catch (e) {
node = FlutterErrorDetails(exception: e).toDiagnosticsNode();
}
final ErrorSummary summary = node.getProperties().whereType<ErrorSummary>().single;
expect(summary.value, equals(<String>['Invalid argument(s) (myArgument): Must not be null']));
}
});
} }