From ab836a2db0b53ffb872866280e5b5527d11ea71c Mon Sep 17 00:00:00 2001 From: Valentin Vignal <32538273+ValentinVignal@users.noreply.github.com> Date: Thu, 8 Feb 2024 02:59:57 +0800 Subject: [PATCH] Add the number of mismatched pixels to golden tests output (#142975) Fixes https://github.com/flutter/flutter/issues/141036 --- packages/flutter_test/lib/src/_goldens_io.dart | 2 +- packages/flutter_test/test/goldens_test.dart | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/flutter_test/lib/src/_goldens_io.dart b/packages/flutter_test/lib/src/_goldens_io.dart index 9d66b83dba..0406c712ea 100644 --- a/packages/flutter_test/lib/src/_goldens_io.dart +++ b/packages/flutter_test/lib/src/_goldens_io.dart @@ -262,7 +262,7 @@ Future compareLists(List? test, List? master) async passed: false, diffPercent: diffPercent, error: 'Pixel test failed, ' - '${(diffPercent * 100).toStringAsFixed(2)}% ' + '${(diffPercent * 100).toStringAsFixed(2)}%, ${pixelDiffCount}px ' 'diff detected.', diffs: { 'masterImage' : masterImage, diff --git a/packages/flutter_test/test/goldens_test.dart b/packages/flutter_test/test/goldens_test.dart index fea9c7eb6d..33066a5782 100644 --- a/packages/flutter_test/test/goldens_test.dart +++ b/packages/flutter_test/test/goldens_test.dart @@ -192,7 +192,7 @@ void main() { throwsA(isFlutterError.having( (FlutterError error) => error.message, 'message', - contains('% diff detected'), + contains('100.00%, 1px diff detected'), )), ); final io.File master = fs.file( @@ -223,7 +223,7 @@ void main() { throwsA(isFlutterError.having( (FlutterError error) => error.message, 'message', - contains('% diff detected'), + contains('100.00%, 1px diff detected'), )), ); final io.File master = fs.file( @@ -302,7 +302,7 @@ void main() { throwsA(isFlutterError.having( (FlutterError error) => error.message, 'message', - contains('% diff detected'), + contains('100.00%, 1px diff detected'), )), ); });