Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)" (#92235)
This reverts commit ba0321e95db8a166c854c4ace5546de35bcb75c5.
This commit is contained in:
parent
be2abc796a
commit
ac3c44355a
@ -17,7 +17,6 @@ Future<dds.DartDevelopmentService> Function(
|
|||||||
bool enableAuthCodes,
|
bool enableAuthCodes,
|
||||||
bool ipv6,
|
bool ipv6,
|
||||||
Uri? serviceUri,
|
Uri? serviceUri,
|
||||||
List<String> cachedUserTags,
|
|
||||||
}) ddsLauncherCallback = dds.DartDevelopmentService.startDartDevelopmentService;
|
}) ddsLauncherCallback = dds.DartDevelopmentService.startDartDevelopmentService;
|
||||||
|
|
||||||
/// Helper class to launch a [dds.DartDevelopmentService]. Allows for us to
|
/// Helper class to launch a [dds.DartDevelopmentService]. Allows for us to
|
||||||
@ -37,7 +36,6 @@ class DartDevelopmentService {
|
|||||||
int? hostPort,
|
int? hostPort,
|
||||||
bool? ipv6,
|
bool? ipv6,
|
||||||
bool? disableServiceAuthCodes,
|
bool? disableServiceAuthCodes,
|
||||||
bool cacheStartupProfile = false,
|
|
||||||
}) async {
|
}) async {
|
||||||
final Uri ddsUri = Uri(
|
final Uri ddsUri = Uri(
|
||||||
scheme: 'http',
|
scheme: 'http',
|
||||||
@ -54,8 +52,6 @@ class DartDevelopmentService {
|
|||||||
serviceUri: ddsUri,
|
serviceUri: ddsUri,
|
||||||
enableAuthCodes: disableServiceAuthCodes != true,
|
enableAuthCodes: disableServiceAuthCodes != true,
|
||||||
ipv6: ipv6 == true,
|
ipv6: ipv6 == true,
|
||||||
// Enables caching of CPU samples collected during application startup.
|
|
||||||
cachedUserTags: cacheStartupProfile ? const <String>['AppStartUp'] : const <String>[],
|
|
||||||
);
|
);
|
||||||
unawaited(_ddsInstance?.done.whenComplete(() {
|
unawaited(_ddsInstance?.done.whenComplete(() {
|
||||||
if (!_completer.isCompleted) {
|
if (!_completer.isCompleted) {
|
||||||
|
@ -70,7 +70,6 @@ Future<void> _kDefaultDartDevelopmentServiceStarter(
|
|||||||
ipv6: true,
|
ipv6: true,
|
||||||
disableServiceAuthCodes: disableServiceAuthCodes,
|
disableServiceAuthCodes: disableServiceAuthCodes,
|
||||||
logger: globals.logger,
|
logger: globals.logger,
|
||||||
cacheStartupProfile: true,
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -267,7 +267,6 @@ class FlutterDevice {
|
|||||||
ipv6: ipv6,
|
ipv6: ipv6,
|
||||||
disableServiceAuthCodes: disableServiceAuthCodes,
|
disableServiceAuthCodes: disableServiceAuthCodes,
|
||||||
logger: globals.logger,
|
logger: globals.logger,
|
||||||
cacheStartupProfile: true,
|
|
||||||
);
|
);
|
||||||
} on dds.DartDevelopmentServiceException catch (e, st) {
|
} on dds.DartDevelopmentServiceException catch (e, st) {
|
||||||
if (!allowExistingDdsInstance ||
|
if (!allowExistingDdsInstance ||
|
||||||
|
@ -772,7 +772,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
|
|||||||
int hostPort,
|
int hostPort,
|
||||||
bool ipv6,
|
bool ipv6,
|
||||||
bool disableServiceAuthCodes,
|
bool disableServiceAuthCodes,
|
||||||
bool cacheStartupProfile = false,
|
|
||||||
}) async {}
|
}) async {}
|
||||||
|
|
||||||
@override
|
@override
|
||||||
|
@ -590,7 +590,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
|
|||||||
int hostPort,
|
int hostPort,
|
||||||
bool ipv6,
|
bool ipv6,
|
||||||
bool disableServiceAuthCodes,
|
bool disableServiceAuthCodes,
|
||||||
bool cacheStartupProfile = false,
|
|
||||||
}) async {
|
}) async {
|
||||||
started = true;
|
started = true;
|
||||||
}
|
}
|
||||||
|
@ -932,7 +932,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
|
|||||||
int hostPort,
|
int hostPort,
|
||||||
bool ipv6,
|
bool ipv6,
|
||||||
bool disableServiceAuthCodes,
|
bool disableServiceAuthCodes,
|
||||||
bool cacheStartupProfile = false,
|
|
||||||
}) async {}
|
}) async {}
|
||||||
|
|
||||||
@override
|
@override
|
||||||
|
@ -1809,12 +1809,11 @@ void main() {
|
|||||||
fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[]);
|
fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[]);
|
||||||
final FakeDevice device = FakeDevice()
|
final FakeDevice device = FakeDevice()
|
||||||
..dds = DartDevelopmentService();
|
..dds = DartDevelopmentService();
|
||||||
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri, List<String> cachedUserTags}) {
|
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri}) {
|
||||||
expect(uri, Uri(scheme: 'foo', host: 'bar'));
|
expect(uri, Uri(scheme: 'foo', host: 'bar'));
|
||||||
expect(enableAuthCodes, isTrue);
|
expect(enableAuthCodes, isTrue);
|
||||||
expect(ipv6, isFalse);
|
expect(ipv6, isFalse);
|
||||||
expect(serviceUri, Uri(scheme: 'http', host: '127.0.0.1', port: 0));
|
expect(serviceUri, Uri(scheme: 'http', host: '127.0.0.1', port: 0));
|
||||||
expect(cachedUserTags, <String>['AppStartUp']);
|
|
||||||
throw FakeDartDevelopmentServiceException(message:
|
throw FakeDartDevelopmentServiceException(message:
|
||||||
'Existing VM service clients prevent DDS from taking control.',
|
'Existing VM service clients prevent DDS from taking control.',
|
||||||
);
|
);
|
||||||
@ -1857,12 +1856,11 @@ void main() {
|
|||||||
final FakeDevice device = FakeDevice()
|
final FakeDevice device = FakeDevice()
|
||||||
..dds = DartDevelopmentService();
|
..dds = DartDevelopmentService();
|
||||||
final Completer<void>done = Completer<void>();
|
final Completer<void>done = Completer<void>();
|
||||||
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri, List<String> cachedUserTags}) async {
|
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri}) async {
|
||||||
expect(uri, Uri(scheme: 'foo', host: 'bar'));
|
expect(uri, Uri(scheme: 'foo', host: 'bar'));
|
||||||
expect(enableAuthCodes, isFalse);
|
expect(enableAuthCodes, isFalse);
|
||||||
expect(ipv6, isTrue);
|
expect(ipv6, isTrue);
|
||||||
expect(serviceUri, Uri(scheme: 'http', host: '::1', port: 0));
|
expect(serviceUri, Uri(scheme: 'http', host: '::1', port: 0));
|
||||||
expect(cachedUserTags, <String>['AppStartUp']);
|
|
||||||
done.complete();
|
done.complete();
|
||||||
return null;
|
return null;
|
||||||
};
|
};
|
||||||
@ -1889,12 +1887,11 @@ void main() {
|
|||||||
// See https://github.com/flutter/flutter/issues/72385 for context.
|
// See https://github.com/flutter/flutter/issues/72385 for context.
|
||||||
final FakeDevice device = FakeDevice()
|
final FakeDevice device = FakeDevice()
|
||||||
..dds = DartDevelopmentService();
|
..dds = DartDevelopmentService();
|
||||||
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri, List<String> cachedUserTags}) {
|
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri}) {
|
||||||
expect(uri, Uri(scheme: 'foo', host: 'bar'));
|
expect(uri, Uri(scheme: 'foo', host: 'bar'));
|
||||||
expect(enableAuthCodes, isTrue);
|
expect(enableAuthCodes, isTrue);
|
||||||
expect(ipv6, isFalse);
|
expect(ipv6, isFalse);
|
||||||
expect(serviceUri, Uri(scheme: 'http', host: '127.0.0.1', port: 0));
|
expect(serviceUri, Uri(scheme: 'http', host: '127.0.0.1', port: 0));
|
||||||
expect(cachedUserTags, <String>['AppStartUp']);
|
|
||||||
throw FakeDartDevelopmentServiceException(message: 'No URI');
|
throw FakeDartDevelopmentServiceException(message: 'No URI');
|
||||||
};
|
};
|
||||||
final TestFlutterDevice flutterDevice = TestFlutterDevice(
|
final TestFlutterDevice flutterDevice = TestFlutterDevice(
|
||||||
|
Loading…
x
Reference in New Issue
Block a user