firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix avoid_renaming_method_parameters for pending analyzer change. (#85482)

Browse Source
This commit is contained in:
Konstantin Scheglov 2021-10-08 09:58:05 -06:00 committed by GitHub
parent a44f3732d0
commit ac88d4ba5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart
View File

@ -347,8 +347,8 @@ abstract class WidgetRecorder extends Recorder implements FrameRecorder {
final List<VoidCallback> _didStopCallbacks = <VoidCallback>[];
@override
void registerDidStop(VoidCallback fn) {
_didStopCallbacks.add(fn);
void registerDidStop(VoidCallback cb) {
_didStopCallbacks.add(cb);
}
@override
@ -443,8 +443,8 @@ abstract class WidgetBuildRecorder extends Recorder implements FrameRecorder {
final List<VoidCallback> _didStopCallbacks = <VoidCallback>[];
@override
void registerDidStop(VoidCallback fn) {
_didStopCallbacks.add(fn);
void registerDidStop(VoidCallback cb) {
_didStopCallbacks.add(cb);
}
@override

4
packages/flutter/lib/src/material/material_localizations.dart
View File

@ -762,10 +762,10 @@ class DefaultMaterialLocalizations implements MaterialLocalizations {
String get dateRangeEndLabel => 'End Date';
@override
String dateRangeStartDateSemanticLabel(String fullDate) => 'Start date $fullDate';
String dateRangeStartDateSemanticLabel(String formattedDate) => 'Start date $formattedDate';
@override
String dateRangeEndDateSemanticLabel(String fullDate) => 'End date $fullDate';
String dateRangeEndDateSemanticLabel(String formattedDate) => 'End date $formattedDate';
@override
String get invalidDateFormatLabel => 'Invalid format.';

12
packages/flutter/lib/src/services/message_codecs.dart
View File

@ -123,10 +123,10 @@ class JSONMethodCodec implements MethodCodec {
const JSONMethodCodec();
@override
ByteData encodeMethodCall(MethodCall call) {
ByteData encodeMethodCall(MethodCall methodCall) {
return const JSONMessageCodec().encodeMessage(<String, Object?>{
'method': call.method,
'args': call.arguments,
'method': methodCall.method,
'args': methodCall.arguments,
})!;
}
@ -555,10 +555,10 @@ class StandardMethodCodec implements MethodCodec {
final StandardMessageCodec messageCodec;
@override
ByteData encodeMethodCall(MethodCall call) {
ByteData encodeMethodCall(MethodCall methodCall) {
final WriteBuffer buffer = WriteBuffer();
messageCodec.writeValue(buffer, call.method);
messageCodec.writeValue(buffer, call.arguments);
messageCodec.writeValue(buffer, methodCall.method);
messageCodec.writeValue(buffer, methodCall.arguments);
return buffer.done();
}

2
packages/flutter/lib/src/widgets/autofill.dart
View File

@ -129,7 +129,7 @@ class AutofillGroupState extends State<AutofillGroup> with AutofillScopeMixin {
bool _isTopmostAutofillGroup = false;
@override
AutofillClient? getAutofillClient(String tag) => _clients[tag];
AutofillClient? getAutofillClient(String autofillId) => _clients[autofillId];
@override
Iterable<AutofillClient> get autofillClients {

8
packages/flutter/lib/src/widgets/scrollable.dart
View File

@ -539,10 +539,10 @@ class ScrollableState extends State<Scrollable> with TickerProviderStateMixin, R
@override
@protected
void setCanDrag(bool canDrag) {
if (canDrag == _lastCanDrag && (!canDrag || widget.axis == _lastAxisDirection))
void setCanDrag(bool value) {
if (value == _lastCanDrag && (!value || widget.axis == _lastAxisDirection))
return;
if (!canDrag) {
if (!value) {
_gestureRecognizers = const <Type, GestureRecognizerFactory>{};
// Cancel the active hold/drag (if any) because the gesture recognizers
// will soon be disposed by our RawGestureDetector, and we won't be
@ -592,7 +592,7 @@ class ScrollableState extends State<Scrollable> with TickerProviderStateMixin, R
break;
}
}
_lastCanDrag = canDrag;
_lastCanDrag = value;
_lastAxisDirection = widget.axis;
if (_gestureDetectorKey.currentState != null)
_gestureDetectorKey.currentState!.replaceGestureRecognizers(_gestureRecognizers);

28
packages/flutter/lib/src/widgets/scrollbar.dart
View File

@ -686,21 +686,21 @@ class ScrollbarPainter extends ChangeNotifier implements CustomPainter {
}
@override
bool shouldRepaint(ScrollbarPainter old) {
bool shouldRepaint(ScrollbarPainter oldDelegate) {
// Should repaint if any properties changed.
return color != old.color
|| trackColor != old.trackColor
|| trackBorderColor != old.trackBorderColor
|| textDirection != old.textDirection
|| thickness != old.thickness
|| fadeoutOpacityAnimation != old.fadeoutOpacityAnimation
|| mainAxisMargin != old.mainAxisMargin
|| crossAxisMargin != old.crossAxisMargin
|| radius != old.radius
|| minLength != old.minLength
|| padding != old.padding
|| minOverscrollLength != old.minOverscrollLength
|| scrollbarOrientation != old.scrollbarOrientation;
return color != oldDelegate.color
|| trackColor != oldDelegate.trackColor
|| trackBorderColor != oldDelegate.trackBorderColor
|| textDirection != oldDelegate.textDirection
|| thickness != oldDelegate.thickness
|| fadeoutOpacityAnimation != oldDelegate.fadeoutOpacityAnimation
|| mainAxisMargin != oldDelegate.mainAxisMargin
|| crossAxisMargin != oldDelegate.crossAxisMargin
|| radius != oldDelegate.radius
|| minLength != oldDelegate.minLength
|| padding != oldDelegate.padding
|| minOverscrollLength != oldDelegate.minOverscrollLength
|| scrollbarOrientation != oldDelegate.scrollbarOrientation;
}
@override

8
packages/flutter/lib/src/widgets/widget_inspector.dart
View File

@ -3247,14 +3247,14 @@ class InspectorSerializationDelegate implements DiagnosticsSerializationDelegate
}
@override
List<DiagnosticsNode> filterChildren(List<DiagnosticsNode> children, DiagnosticsNode owner) {
return service._filterChildren(children, this);
List<DiagnosticsNode> filterChildren(List<DiagnosticsNode> nodes, DiagnosticsNode owner) {
return service._filterChildren(nodes, this);
}
@override
List<DiagnosticsNode> filterProperties(List<DiagnosticsNode> properties, DiagnosticsNode owner) {
List<DiagnosticsNode> filterProperties(List<DiagnosticsNode> nodes, DiagnosticsNode owner) {
final bool createdByLocalProject = _nodesCreatedByLocalProject.contains(owner);
return properties.where((DiagnosticsNode node) {
return nodes.where((DiagnosticsNode node) {
return !node.isFiltered(createdByLocalProject ? DiagnosticLevel.fine : DiagnosticLevel.info);
}).toList();
}

14
packages/flutter_localizations/lib/src/material_localizations.dart
View File

@ -246,8 +246,8 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
String get dateRangeStartDateSemanticLabelRaw;
@override
String dateRangeStartDateSemanticLabel(String fullDate) {
return dateRangeStartDateSemanticLabelRaw.replaceFirst(r'$fullDate', fullDate);
String dateRangeStartDateSemanticLabel(String formattedDate) {
return dateRangeStartDateSemanticLabelRaw.replaceFirst(r'$fullDate', formattedDate);
}
/// The raw version of [dateRangeEndDateSemanticLabel], with `$fullDate` verbatim
@ -256,8 +256,8 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
String get dateRangeEndDateSemanticLabelRaw;
@override
String dateRangeEndDateSemanticLabel(String fullDate) {
return dateRangeEndDateSemanticLabelRaw.replaceFirst(r'$fullDate', fullDate);
String dateRangeEndDateSemanticLabel(String formattedDate) {
return dateRangeEndDateSemanticLabelRaw.replaceFirst(r'$fullDate', formattedDate);
}
/// The raw version of [aboutListTileTitle], with `$applicationName` verbatim
@ -646,9 +646,9 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
String get remainingTextFieldCharacterCountOther;
@override
String remainingTextFieldCharacterCount(int remainingCount) {
String remainingTextFieldCharacterCount(int remaining) {
return intl.Intl.pluralLogic(
remainingCount,
remaining,
zero: remainingTextFieldCharacterCountZero,
one: remainingTextFieldCharacterCountOne,
two: remainingTextFieldCharacterCountTwo,
@ -656,7 +656,7 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
few: remainingTextFieldCharacterCountFew,
other: remainingTextFieldCharacterCountOther,
locale: _localeName,
).replaceFirst(r'$remainingCount', formatDecimal(remainingCount));
).replaceFirst(r'$remainingCount', formatDecimal(remaining));
}
@override