firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix flutter shell script to handle properly shells that have CDPATH set (#17589)

Browse Source 
Before this change, if CDPATH was set, and you type (from the flutter root) "bin/flutter --version" you would get an error.

This is because the cd command in follow_links was printing the directory Bash chose from the CDPATH to stdout, causing the path to have a newline in it, which understandably confuses the rest of the script.
This commit is contained in:
Greg Spencer 2018-05-14 17:11:38 -07:00 committed by GitHub
parent a25bbc7bfc
commit ace27819fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bin/flutter
View File

@ -14,6 +14,8 @@
set -e set -e
unset CDPATH
function follow_links() { function follow_links() {
cd -P "${1%/*}" cd -P "${1%/*}"
local file="$PWD/${1##*/}" local file="$PWD/${1##*/}"