From ad44b05ca40e58a29940986373394326db3bd127 Mon Sep 17 00:00:00 2001 From: Shi-Hao Hong Date: Tue, 3 Mar 2020 14:03:05 -0800 Subject: [PATCH] Revert "AlertDialog widget scrollable by default (#49848)" (#51886) This reverts commit 28f2c96a8a63ca75700b307692b3bc691d6d010c. --- packages/flutter/lib/src/material/dialog.dart | 2 +- packages/flutter/test/material/dialog_test.dart | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/material/dialog.dart b/packages/flutter/lib/src/material/dialog.dart index 4a68d13c6a..be0f638321 100644 --- a/packages/flutter/lib/src/material/dialog.dart +++ b/packages/flutter/lib/src/material/dialog.dart @@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget { this.insetPadding = _defaultInsetPadding, this.clipBehavior = Clip.none, this.shape, - this.scrollable = true, + this.scrollable = false, }) : assert(contentPadding != null), assert(clipBehavior != null), super(key: key); diff --git a/packages/flutter/test/material/dialog_test.dart b/packages/flutter/test/material/dialog_test.dart index 02e9293026..2bd1161831 100644 --- a/packages/flutter/test/material/dialog_test.dart +++ b/packages/flutter/test/material/dialog_test.dart @@ -1100,6 +1100,7 @@ void main() { color: Colors.green, height: 1000, ), + scrollable: true, ); await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.tap(find.text('X')); @@ -1119,6 +1120,7 @@ void main() { color: Colors.orange, height: 1000, ), + scrollable: true, ); await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.tap(find.text('X')); @@ -1144,6 +1146,7 @@ void main() { color: Colors.orange, height: 400, ), + scrollable: true, ); await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.tap(find.text('X'));