From adf998cb2abd65c3347cddcc547e78f314e16fa7 Mon Sep 17 00:00:00 2001 From: Yegor Date: Tue, 6 Dec 2016 12:20:54 -0800 Subject: [PATCH] remove mega_gallery__refresh_time superseded by hot_mode_dev_cycle__benchmark (#7171) --- .../bin/tasks/mega_gallery__refresh_time.dart | 18 ----- dev/devicelab/lib/tasks/refresh.dart | 75 ------------------- dev/devicelab/manifest.yaml | 6 -- 3 files changed, 99 deletions(-) delete mode 100644 dev/devicelab/bin/tasks/mega_gallery__refresh_time.dart delete mode 100644 dev/devicelab/lib/tasks/refresh.dart diff --git a/dev/devicelab/bin/tasks/mega_gallery__refresh_time.dart b/dev/devicelab/bin/tasks/mega_gallery__refresh_time.dart deleted file mode 100644 index 1bb289b7aa..0000000000 --- a/dev/devicelab/bin/tasks/mega_gallery__refresh_time.dart +++ /dev/null @@ -1,18 +0,0 @@ -// Copyright 2016 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'dart:async'; - -import 'package:flutter_devicelab/tasks/refresh.dart'; -import 'package:flutter_devicelab/framework/framework.dart'; -import 'package:flutter_devicelab/framework/utils.dart'; - -Future main() async { - String revision = await getCurrentFlutterRepoCommit(); - DateTime revisionTimestamp = await getFlutterRepoCommitTimestamp(revision); - await task(createRefreshTest( - commit: revision, - timestamp: revisionTimestamp, - )); -} diff --git a/dev/devicelab/lib/tasks/refresh.dart b/dev/devicelab/lib/tasks/refresh.dart deleted file mode 100644 index ce99ffd2a9..0000000000 --- a/dev/devicelab/lib/tasks/refresh.dart +++ /dev/null @@ -1,75 +0,0 @@ -// Copyright (c) 2016 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'dart:async'; -import 'dart:io'; - -import 'package:path/path.dart' as path; - -import '../framework/adb.dart'; -import '../framework/benchmarks.dart'; -import '../framework/framework.dart'; -import '../framework/utils.dart'; - -TaskFunction createRefreshTest({ String commit, DateTime timestamp }) => - new EditRefreshTask(commit, timestamp); - -class EditRefreshTask { - EditRefreshTask(this.commit, this.timestamp) { - assert(commit != null); - assert(timestamp != null); - } - - final String commit; - final DateTime timestamp; - - Future call() async { - Device device = await devices.workingDevice; - await device.unlock(); - Benchmark benchmark = new EditRefreshBenchmark(commit, timestamp); - section(benchmark.name); - await runBenchmark(benchmark, iterations: 3, warmUpBenchmark: true); - return benchmark.bestResult; - } -} - -class EditRefreshBenchmark extends Benchmark { - EditRefreshBenchmark(this.commit, this.timestamp) : super('edit refresh'); - - final String commit; - final DateTime timestamp; - - Directory get megaDir => dir( - path.join(flutterDirectory.path, 'dev/benchmarks/mega_gallery')); - File get benchmarkFile => - file(path.join(megaDir.path, 'refresh_benchmark.json')); - - @override - TaskResult get lastResult => new TaskResult.successFromFile(benchmarkFile); - - @override - Future init() { - return inDirectory(flutterDirectory, () async { - await dart(['dev/tools/mega_gallery.dart']); - }); - } - - @override - Future run() async { - Device device = await devices.workingDevice; - rm(benchmarkFile); - int exitCode = await inDirectory(megaDir, () async { - return await flutter('run', - options: ['-d', device.deviceId, '--benchmark'], - canFail: true); - }); - if (exitCode != 0) return new Future.error(exitCode); - return addBuildInfo( - benchmarkFile, - timestamp: timestamp, - expected: 200, - commit: commit, - ); - } -} diff --git a/dev/devicelab/manifest.yaml b/dev/devicelab/manifest.yaml index b6f5a16914..9a29b91bf1 100644 --- a/dev/devicelab/manifest.yaml +++ b/dev/devicelab/manifest.yaml @@ -97,12 +97,6 @@ tasks: stage: devicelab required_agent_capabilities: ["has-android-device"] - mega_gallery__refresh_time: - description: > - Measures AOT snapshot rebuild performance on a generated large app. - stage: devicelab - required_agent_capabilities: ["has-android-device"] - hot_mode_dev_cycle__benchmark: description: > Measures the performance of Dart VM hot patching feature.