firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bad pattern in 2D tests (#132709)

Browse Source 
Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536
This commit is contained in:
Kate Lovett 2023-08-16 19:13:04 -05:00 committed by GitHub
parent 1a0077dc81
commit af0ca97842
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/flutter/test/widgets/two_dimensional_viewport_test.dart
View File

@ -1514,7 +1514,7 @@ void main() {
maxXIndex: 5,
maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200);
}
);
@ -1602,7 +1602,7 @@ void main() {
maxXIndex: 5,
maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200);
}
);
@ -1731,7 +1731,7 @@ void main() {
maxXIndex: 5,
maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200);
}
);
@ -1897,7 +1897,7 @@ void main() {
maxXIndex: 19,
maxYIndex: 19,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(
dimension: 200,
child: Center(
@ -1965,7 +1965,7 @@ void main() {
maxXIndex: 5,
maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200);
}
);
@ -2001,7 +2001,7 @@ void main() {
maxXIndex: 5,
maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200);
}
);
@ -2119,7 +2119,7 @@ void main() {
maxXIndex: 5,
maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey();
childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200);
}
);