firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RenderParagraph should dispose instances of SelectableFragments. (#133915)

Browse Source
This commit is contained in:
Polina Cherkasova 2023-09-05 13:40:14 -07:00 committed by GitHub
parent c9f70e9fd2
commit af1b7494d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/rendering/paragraph.dart
View File

@ -437,9 +437,7 @@ class RenderParagraph extends RenderBox with ContainerRenderObjectMixin<RenderBo
@override @override
void dispose() { void dispose() {
_removeSelectionRegistrarSubscription(); _removeSelectionRegistrarSubscription();
// _lastSelectableFragments may hold references to this RenderParagraph. _disposeSelectableFragments();
// Release them manually to avoid retain cycles.
_lastSelectableFragments = null;
_textPainter.dispose(); _textPainter.dispose();
super.dispose(); super.dispose();
} }

2
packages/flutter/test/material/elevated_button_test.dart
View File

@ -1684,7 +1684,7 @@ void main() {
expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.basic); expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.basic);
}); });
testWidgets('ElevatedButton in SelectionArea changes mouse cursor when hovered', (WidgetTester tester) async { testWidgetsWithLeakTracking('ElevatedButton in SelectionArea changes mouse cursor when hovered', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/104595. // Regression test for https://github.com/flutter/flutter/issues/104595.
await tester.pumpWidget(MaterialApp( await tester.pumpWidget(MaterialApp(
home: SelectionArea( home: SelectionArea(