From b13770f65a4513fe977b935804b0a065fc6cccd7 Mon Sep 17 00:00:00 2001 From: Gray Mackall <34871572+gmackall@users.noreply.github.com> Date: Fri, 22 Nov 2024 11:00:19 -0800 Subject: [PATCH] Manually update strings after dca37ad, and turn `packages_autoroller` back on (#159343) Updates strings to reflect changes from https://github.com/flutter/flutter/commit/dca37ad17ff0354924f9b5bbbcbb2ce6ed819230 Reason: https://github.com/flutter/flutter/issues/159316#issuecomment-2494445095 Fixes https://github.com/flutter/flutter/issues/159316 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall --- .ci.yaml | 1 - dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_en.dart | 2 ++ dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_es.dart | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.ci.yaml b/.ci.yaml index a9842eb91e..1aa37d8e71 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -392,7 +392,6 @@ targets: - name: Linux packages_autoroller presubmit: false - bringup: true # https://github.com/flutter/flutter/issues/159316 recipe: pub_autoroller/pub_autoroller # This takes a while because we need to fetch network dependencies and run # Gradle for every android app in the repo diff --git a/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_en.dart b/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_en.dart index 7865abd9a2..094331da2e 100644 --- a/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_en.dart +++ b/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_en.dart @@ -5,6 +5,8 @@ // THE FOLLOWING FILES WERE GENERATED BY `flutter gen-l10n`. +// ignore: unused_import +import 'package:intl/intl.dart' as intl; import 'stock_strings.dart'; // ignore_for_file: type=lint diff --git a/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_es.dart b/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_es.dart index c49643aca0..4b2754145f 100644 --- a/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_es.dart +++ b/dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_es.dart @@ -5,6 +5,8 @@ // THE FOLLOWING FILES WERE GENERATED BY `flutter gen-l10n`. +// ignore: unused_import +import 'package:intl/intl.dart' as intl; import 'stock_strings.dart'; // ignore_for_file: type=lint