firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

implement Iterator and Comparable instead of extending them (#123282)

Browse Source 
implement Iterator and Comparable instead of extending them
This commit is contained in:
Jacob MacDonald 2023-03-23 10:10:31 -07:00 committed by GitHub
parent 5a36bddd2b
commit b212e7b32b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/integration_tests/flutter_gallery/lib/demo/transformations/transformations_demo_board.dart
View File

@ -200,7 +200,7 @@ class Board extends IterableMixin<BoardPoint?> {
} }
} }
class _BoardIterator extends Iterator<BoardPoint?> { class _BoardIterator implements Iterator<BoardPoint?> {
_BoardIterator(this.boardPoints); _BoardIterator(this.boardPoints);
final List<BoardPoint> boardPoints; final List<BoardPoint> boardPoints;

2
packages/flutter/lib/src/rendering/editable.dart
View File

@ -131,7 +131,7 @@ class TextSelectionPoint {
/// the [VerticalCaretMovementRun] must not be used. The [isValid] property must /// the [VerticalCaretMovementRun] must not be used. The [isValid] property must
/// be checked before calling [movePrevious], [moveNext] and [moveByOffset], /// be checked before calling [movePrevious], [moveNext] and [moveByOffset],
/// or accessing [current]. /// or accessing [current].
class VerticalCaretMovementRun extends Iterator<TextPosition> { class VerticalCaretMovementRun implements Iterator<TextPosition> {
VerticalCaretMovementRun._( VerticalCaretMovementRun._(
this._editable, this._editable,
this._lineMetrics, this._lineMetrics,

2
packages/flutter/lib/src/semantics/semantics.dart
View File

@ -2875,7 +2875,7 @@ class _BoxEdge implements Comparable<_BoxEdge> {
/// nodes that share the same [SemanticsNode] parent. /// nodes that share the same [SemanticsNode] parent.
/// ///
/// The [nodes] are sorted among each other separately from other nodes. /// The [nodes] are sorted among each other separately from other nodes.
class _SemanticsSortGroup extends Comparable<_SemanticsSortGroup> { class _SemanticsSortGroup implements Comparable<_SemanticsSortGroup> {
_SemanticsSortGroup({ _SemanticsSortGroup({
required this.startOffset, required this.startOffset,
required this.textDirection, required this.textDirection,