firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] check both linear sampling props for AHBs. (#162043)

Browse Source 
According to
https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/5806 ,
both eSampledImageYcbcrConversionLinearFilter and
eSampledImageFilterLinear properties are required to use a linear
chromaFilter.
This commit is contained in:
Jonah Williams 2025-01-23 07:48:55 -08:00 committed by GitHub
parent 6a8d77dccd
commit b46479c6a0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/src/flutter/impeller/renderer/backend/vulkan/android/ahb_texture_source_vk.cc
View File

@ -146,10 +146,13 @@ static std::shared_ptr<YUVConversionVK> CreateYUVConversion(
const auto& ahb_format =
ahb_props.get<vk::AndroidHardwareBufferFormatPropertiesANDROID>();
// See https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/5806
// Both features are required.
const bool supports_linear_filtering =
!!(ahb_format.formatFeatures &
vk::FormatFeatureFlagBits::eSampledImageYcbcrConversionLinearFilter);
vk::FormatFeatureFlagBits::eSampledImageYcbcrConversionLinearFilter) &&
!!(ahb_format.formatFeatures &
vk::FormatFeatureFlagBits::eSampledImageFilterLinear);
auto& conversion_info = conversion_chain.get();
conversion_info.format = ahb_format.format;
@ -160,6 +163,7 @@ static std::shared_ptr<YUVConversionVK> CreateYUVConversion(
conversion_info.yChromaOffset = ahb_format.suggestedYChromaOffset;
conversion_info.chromaFilter =
supports_linear_filtering ? vk::Filter::eLinear : vk::Filter::eNearest;
conversion_info.forceExplicitReconstruction = false;
if (conversion_info.format == vk::Format::eUndefined) {
@ -297,7 +301,6 @@ AHBTextureSourceVK::AHBTextureSourceVK(
}
const auto& context = ContextVK::Cast(*p_context);
const auto& device = context.GetDevice();
const auto& physical_device = context.GetPhysicalDevice();