firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use default value for ResultData when uploading metrics from test runner (#88749)

Browse Source
This commit is contained in:
keyonghan 2021-08-24 12:04:03 -07:00 committed by GitHub
parent b68cdfcf44
commit b468be3030
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dev/devicelab/lib/framework/metrics_center.dart
View File

@ -45,11 +45,13 @@ Future<FlutterDestination> connectFlutterDestination() async {
/// ] /// ]
/// } /// }
List<MetricPoint> parse(Map<String, dynamic> resultsJson) { List<MetricPoint> parse(Map<String, dynamic> resultsJson) {
final List<String> scoreKeys = (resultsJson['BenchmarkScoreKeys'] as List<dynamic>).cast<String>(); final List<String> scoreKeys =
final Map<String, dynamic> resultData = resultsJson['ResultData'] as Map<String, dynamic>; (resultsJson['BenchmarkScoreKeys'] as List<dynamic>?)?.cast<String>() ?? const <String>[];
final Map<String, dynamic> resultData =
resultsJson['ResultData'] as Map<String, dynamic>? ?? const <String, dynamic>{};
final String gitBranch = (resultsJson['CommitBranch'] as String).trim(); final String gitBranch = (resultsJson['CommitBranch'] as String).trim();
final String gitSha = (resultsJson['CommitSha'] as String).trim(); final String gitSha = (resultsJson['CommitSha'] as String).trim();
final String builderName = resultsJson['BuilderName'] as String; final String builderName = (resultsJson['BuilderName'] as String).trim();
final List<MetricPoint> metricPoints = <MetricPoint>[]; final List<MetricPoint> metricPoints = <MetricPoint>[];
for (final String scoreKey in scoreKeys) { for (final String scoreKey in scoreKeys) {
metricPoints.add( metricPoints.add(

19
dev/devicelab/test/metrics_center_test.dart
View File

@ -16,17 +16,30 @@ void main() {
'BuilderName': 'test', 'BuilderName': 'test',
'ResultData': <String, dynamic>{ 'ResultData': <String, dynamic>{
'average_frame_build_time_millis': 0.4550425531914895, 'average_frame_build_time_millis': 0.4550425531914895,
'90th_percentile_frame_build_time_millis': 0.473 '90th_percentile_frame_build_time_millis': 0.473,
}, },
'BenchmarkScoreKeys': <String>[ 'BenchmarkScoreKeys': <String>[
'average_frame_build_time_millis', 'average_frame_build_time_millis',
'90th_percentile_frame_build_time_millis' '90th_percentile_frame_build_time_millis',
] ],
}; };
final List<MetricPoint> metricPoints = parse(results); final List<MetricPoint> metricPoints = parse(results);
expect(metricPoints[0].value, equals(0.4550425531914895)); expect(metricPoints[0].value, equals(0.4550425531914895));
expect(metricPoints[1].value, equals(0.473)); expect(metricPoints[1].value, equals(0.473));
}); });
test('succeeds - null ResultData', () {
final Map<String, dynamic> results = <String, dynamic>{
'CommitBranch': 'master',
'CommitSha': 'abc',
'BuilderName': 'test',
'ResultData': null,
'BenchmarkScoreKeys': null,
};
final List<MetricPoint> metricPoints = parse(results);
expect(metricPoints.length, 0);
});
}); });
} }