firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a typo in Dialog

Browse Source 
If action: was specified, content: was added twice.

R=jackson@google.com

Review URL: https://codereview.chromium.org/1188303002.
This commit is contained in:
Hans Muller 2015-06-17 10:06:44 -07:00
parent 5c1d903644
commit b7bc781a72
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/tests/widgets/dialog-expected.txt
View File

@ -13,12 +13,14 @@ PAINT FOR FRAME #2 ----------------------------------------------
2 | | | drawRect(Rect.fromLTRB(0.0, 0.0, 800.0, 600.0), Paint(Color(0x7f000000))) 2 | | | drawRect(Rect.fromLTRB(0.0, 0.0, 800.0, 600.0), Paint(Color(0x7f000000)))
2 | | paintChild RenderPositionedBox at Point(0.0, 0.0) 2 | | paintChild RenderPositionedBox at Point(0.0, 0.0)
2 | | | TestDisplayList() constructor: 800.0 x 600.0 2 | | | TestDisplayList() constructor: 800.0 x 600.0
2 | | | paintChild RenderConstrainedBox at Point(260.0, 284.0) 2 | | | paintChild RenderConstrainedBox at Point(260.0, 276.0)
2 | | | | TestDisplayList() constructor: 800.0 x 600.0 2 | | | | TestDisplayList() constructor: 800.0 x 600.0
2 | | | | drawRRect(Instance of 'RRect', Paint(Color(0xfffafafa))) 2 | | | | drawRRect(Instance of 'RRect', Paint(Color(0xfffafafa)))
2 | | | | paintChild RenderParagraph at Point(0.0, 0.0) 2 | | | | paintChild RenderParagraph at Point(0.0, 0.0)
2 | | | | | TestDisplayList() constructor: 800.0 x 600.0 2 | | | | | TestDisplayList() constructor: 800.0 x 600.0
2 | | | | paintChild RenderParagraph at Point(0.0, 16.0) 2 | | | | paintChild RenderParagraph at Point(0.0, 16.0)
2 | | | | | TestDisplayList() constructor: 800.0 x 600.0 2 | | | | | TestDisplayList() constructor: 800.0 x 600.0
2 | | | | paintChild RenderParagraph at Point(0.0, 32.0)
2 | | | | | TestDisplayList() constructor: 800.0 x 600.0
------------------------------------------------------------------------ ------------------------------------------------------------------------
PAINTED 2 FRAMES PAINTED 2 FRAMES

3
engine/src/flutter/tests/widgets/dialog.dart
View File

@ -13,7 +13,8 @@ main() async {
await tester.test(() { await tester.test(() {
return new Dialog( return new Dialog(
title: new Text("I am a title"), title: new Text("I am a title"),
content: new Text("I am some content") content: new Text("I am some content"),
actions: new Text("I am some actions")
); );
}); });