firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DropdownButton layout (#4582)

Browse Source
This commit is contained in:
Hans Muller 2016-06-21 15:20:35 -07:00 committed by GitHub
parent 0e38cba95f
commit b81229b5f1
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/flutter/lib/src/material/drop_down.dart
View File

@ -19,7 +19,7 @@ import 'material.dart';
const Duration _kDropDownMenuDuration = const Duration(milliseconds: 300); const Duration _kDropDownMenuDuration = const Duration(milliseconds: 300);
const double _kMenuItemHeight = 48.0; const double _kMenuItemHeight = 48.0;
const EdgeInsets _kMenuVerticalPadding = const EdgeInsets.symmetric(vertical: 8.0); const EdgeInsets _kMenuVerticalPadding = const EdgeInsets.symmetric(vertical: 8.0);
const EdgeInsets _kMenuHorizontalPadding = const EdgeInsets.symmetric(horizontal: 36.0); const EdgeInsets _kMenuHorizontalPadding = const EdgeInsets.symmetric(horizontal: 4.0);
const double _kBaselineOffsetFromBottom = 20.0; const double _kBaselineOffsetFromBottom = 20.0;
const double _kBottomBorderHeight = 2.0; const double _kBottomBorderHeight = 2.0;
const Border _kDropDownUnderline = const Border(bottom: const BorderSide(color: const Color(0xFFBDBDBD), width: _kBottomBorderHeight)); const Border _kDropDownUnderline = const Border(bottom: const BorderSide(color: const Color(0xFFBDBDBD), width: _kBottomBorderHeight));
@ -424,8 +424,6 @@ class DropDownButton<T> extends StatefulWidget {
} }
class _DropDownButtonState<T> extends State<DropDownButton<T>> { class _DropDownButtonState<T> extends State<DropDownButton<T>> {
final GlobalKey _itemKey = new GlobalKey(debugLabel: 'DropDownButton item key');
@override @override
void initState() { void initState() {
super.initState(); super.initState();
@ -456,7 +454,7 @@ class _DropDownButtonState<T> extends State<DropDownButton<T>> {
void _handleTap() { void _handleTap() {
assert(_currentRoute == null); assert(_currentRoute == null);
final RenderBox itemBox = _itemKey.currentContext.findRenderObject(); final RenderBox itemBox = context.findRenderObject();
final Rect itemRect = itemBox.localToGlobal(Point.origin) & itemBox.size; final Rect itemRect = itemBox.localToGlobal(Point.origin) & itemBox.size;
final Completer<_DropDownRouteResult<T>> completer = new Completer<_DropDownRouteResult<T>>(); final Completer<_DropDownRouteResult<T>> completer = new Completer<_DropDownRouteResult<T>>();
_currentRoute = new _DropDownRoute<T>( _currentRoute = new _DropDownRoute<T>(
@ -485,13 +483,12 @@ class _DropDownButtonState<T> extends State<DropDownButton<T>> {
Widget result = new DefaultTextStyle( Widget result = new DefaultTextStyle(
style: style, style: style,
child: new Row( child: new Row(
mainAxisSize: MainAxisSize.min,
mainAxisAlignment: MainAxisAlignment.spaceBetween, mainAxisAlignment: MainAxisAlignment.spaceBetween,
mainAxisSize: MainAxisSize.min,
children: <Widget>[ children: <Widget>[
// We use an IndexedStack to make sure we have enough width to show any // We use an IndexedStack to make sure we have enough width to show any
// possible item as the selected item without changing size. // possible item as the selected item without changing size.
new IndexedStack( new IndexedStack(
key: _itemKey,
index: _selectedIndex, index: _selectedIndex,
alignment: FractionalOffset.centerLeft, alignment: FractionalOffset.centerLeft,
children: config.items children: config.items