From b928b3c1c312d5565f4789d25756b62f90e997c5 Mon Sep 17 00:00:00 2001 From: Jackson Gardner Date: Mon, 31 Jul 2023 13:17:34 -0700 Subject: [PATCH] Reland --omit-type-checks for benchmarks. (#131493) Because the cost of type checks dominate our dart2wasm benchmarks, we've decided to pass `--omit-type-checks` for now. This was previously reverted because the skwasm benchmarks were broken in general for a separate reason, and my getting rid of `bringup: true` broke the tree. I ended up fixing the benchmarks and getting rid of `bringup: true` in a separate commit, so this just adds the flag only. --- dev/devicelab/lib/tasks/web_benchmarks.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/dev/devicelab/lib/tasks/web_benchmarks.dart b/dev/devicelab/lib/tasks/web_benchmarks.dart index 051133c70d..a4748b8f9f 100644 --- a/dev/devicelab/lib/tasks/web_benchmarks.dart +++ b/dev/devicelab/lib/tasks/web_benchmarks.dart @@ -36,6 +36,7 @@ Future runWebBenchmark(WebBenchmarkOptions benchmarkOptions) async { if (benchmarkOptions.useWasm) ...[ '--wasm', '--wasm-opt=debug', + '--omit-type-checks', ], '--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true', '--web-renderer=${benchmarkOptions.webRenderer}',