firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make sure test reporter prints out stderr, and disables Bigquery for non-contributors (#29073)

Browse Source 
* print stderr to stderr, no bq if not contributor

* let test continue of bigquery fails
This commit is contained in:
Dan Field 2019-03-10 11:26:17 -07:00 committed by GitHub
parent 837b330fcd
commit b9f013c044
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dev/bots/flutter_compact_formatter.dart
View File

@ -129,9 +129,16 @@ class FlutterCompactFormatter {
} }
break; break;
case 'error': case 'error':
final String error = decoded['error'];
final String stackTrace = decoded['stackTrace'];
if (originalResult != null) { if (originalResult != null) {
originalResult.errorMessage = decoded['error']; originalResult.errorMessage = error;
originalResult.stackTrace = decoded['stackTrace']; originalResult.stackTrace = stackTrace;
} else {
if (error != null)
stderr.writeln(error);
if (stackTrace != null)
stderr.writeln(stackTrace);
} }
break; break;
case 'print': case 'print':

1
dev/bots/run_command.dart
View File

@ -50,6 +50,7 @@ Stream<String> runAndGetStdout(String executable, List<String> arguments, {
environment: environment, environment: environment,
); );
stderr.addStream(process.stderr);
final Stream<String> lines = process.stdout.transform(utf8.decoder).transform(const LineSplitter()); final Stream<String> lines = process.stdout.transform(utf8.decoder).transform(const LineSplitter());
await for (String line in lines) { await for (String line in lines) {
yield line; yield line;

9
dev/bots/test.dart
View File

@ -148,9 +148,11 @@ Future<void> _runSmokeTests() async {
Future<bq.BigqueryApi> _getBigqueryApi() async { Future<bq.BigqueryApi> _getBigqueryApi() async {
// TODO(dnfield): How will we do this on LUCI? // TODO(dnfield): How will we do this on LUCI?
final String privateKey = Platform.environment['GCLOUD_SERVICE_ACCOUNT_KEY']; final String privateKey = Platform.environment['GCLOUD_SERVICE_ACCOUNT_KEY'];
if (privateKey == null || privateKey.isEmpty) { // If we're on Cirrus and a non-collaborator is doing this, we can't get the key.
if (privateKey == null || privateKey.isEmpty || privateKey.startsWith('ENCRYPTED[')) {
return null; return null;
} }
try {
final auth.ServiceAccountCredentials accountCredentials = auth.ServiceAccountCredentials( //.fromJson(credentials); final auth.ServiceAccountCredentials accountCredentials = auth.ServiceAccountCredentials( //.fromJson(credentials);
'flutter-ci-test-reporter@flutter-infra.iam.gserviceaccount.com', 'flutter-ci-test-reporter@flutter-infra.iam.gserviceaccount.com',
auth.ClientId.serviceAccount('114390419920880060881.apps.googleusercontent.com'), auth.ClientId.serviceAccount('114390419920880060881.apps.googleusercontent.com'),
@ -159,6 +161,11 @@ Future<bq.BigqueryApi> _getBigqueryApi() async {
final List<String> scopes = <String>[bq.BigqueryApi.BigqueryInsertdataScope]; final List<String> scopes = <String>[bq.BigqueryApi.BigqueryInsertdataScope];
final http.Client client = await auth.clientViaServiceAccount(accountCredentials, scopes); final http.Client client = await auth.clientViaServiceAccount(accountCredentials, scopes);
return bq.BigqueryApi(client); return bq.BigqueryApi(client);
} catch (e) {
print('Failed to get BigQuery API client.');
print(e);
return null;
}
} }
Future<void> _runToolTests() async { Future<void> _runToolTests() async {