firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some logs to catch flake (#109887)

Browse Source
This commit is contained in:
Michael Goderbauer 2022-08-19 16:30:19 -07:00 committed by GitHub
parent 74f5a1fe2c
commit ba8bc53825
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dev/integration_tests/channels/test_driver/main_test.dart
View File

@ -18,6 +18,7 @@ void main() {
final SerializableFinder statusField = find.byValueKey('status'); final SerializableFinder statusField = find.byValueKey('status');
int step = 0; int step = 0;
while (await driver.getText(statusField) == 'ok') { while (await driver.getText(statusField) == 'ok') {
print('Tapping for step $step...');
await driver.tap(stepButton); await driver.tap(stepButton);
step++; step++;
} }

2
packages/flutter/lib/src/gestures/binding.dart
View File

@ -360,7 +360,7 @@ mixin GestureBinding on BindingBase implements HitTestable, HitTestDispatcher, H
void _handlePointerEventImmediately(PointerEvent event) { void _handlePointerEventImmediately(PointerEvent event) {
HitTestResult? hitTestResult; HitTestResult? hitTestResult;
if (event is PointerDownEvent || event is PointerSignalEvent || event is PointerHoverEvent || event is PointerPanZoomStartEvent) { if (event is PointerDownEvent || event is PointerSignalEvent || event is PointerHoverEvent || event is PointerPanZoomStartEvent) {
assert(!_hitTests.containsKey(event.pointer)); assert(!_hitTests.containsKey(event.pointer), 'Pointer of $event unexpectedly has a HitTestResult associated with it.');
hitTestResult = HitTestResult(); hitTestResult = HitTestResult();
hitTest(hitTestResult, event.position); hitTest(hitTestResult, event.position);
if (event is PointerDownEvent || event is PointerPanZoomStartEvent) { if (event is PointerDownEvent || event is PointerPanZoomStartEvent) {