firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix RenderListTile actual baseline computation (#17915)

Browse Source 
It should be calling `tile.getDistanceToActualBaseline()` rather than
`tile.getDistanceToBaseline()`.  This is causing us to hit assertions
`getDistanceToBaseline()`
This commit is contained in:
Todd Volkert 2018-05-25 13:15:34 -07:00 committed by GitHub
parent e816b89a1f
commit bae78a6f73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/list_tile.dart
View File

@ -713,7 +713,7 @@ class _RenderListTile extends RenderBox {
double computeDistanceToActualBaseline(TextBaseline baseline) { double computeDistanceToActualBaseline(TextBaseline baseline) {
assert(title != null); assert(title != null);
final BoxParentData parentData = title.parentData; final BoxParentData parentData = title.parentData;
return parentData.offset.dy + title.getDistanceToBaseline(TextBaseline.alphabetic); return parentData.offset.dy + title.getDistanceToActualBaseline(TextBaseline.alphabetic);
} }
static double _boxBaseline(RenderBox box) { static double _boxBaseline(RenderBox box) {