firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable tests that fail on non-master branches from running on those branches (#45455)

Browse Source 
https://github.com/flutter/flutter/issues/45453
This commit is contained in:
Todd Volkert 2019-11-24 22:29:28 -08:00 committed by GitHub
parent 980f14e0c5
commit bae92c32e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
.cirrus.yml
View File

@ -229,6 +229,7 @@ task:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-0-linux - name: hostonly_devicelab_tests-0-linux
only_if: "$CIRRUS_PR != '' || $CIRRUS_BRANCH == 'master'" # https://github.com/flutter/flutter/issues/45453
environment: environment:
# Some of the host-only devicelab tests are pretty involved and need a lot of RAM. # Some of the host-only devicelab tests are pretty involved and need a lot of RAM.
CPU: 2 CPU: 2
@ -237,6 +238,7 @@ task:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-1-linux - name: hostonly_devicelab_tests-1-linux
only_if: "$CIRRUS_PR != '' || $CIRRUS_BRANCH == 'master'" # https://github.com/flutter/flutter/issues/45453
environment: environment:
# Some of the host-only devicelab tests are pretty involved and need a lot of RAM. # Some of the host-only devicelab tests are pretty involved and need a lot of RAM.
CPU: 2 CPU: 2
@ -245,6 +247,7 @@ task:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-2-linux - name: hostonly_devicelab_tests-2-linux
only_if: "$CIRRUS_PR != '' || $CIRRUS_BRANCH == 'master'" # https://github.com/flutter/flutter/issues/45453
environment: environment:
# Some of the host-only devicelab tests are pretty involved and need a lot of RAM. # Some of the host-only devicelab tests are pretty involved and need a lot of RAM.
CPU: 2 CPU: 2
@ -253,6 +256,7 @@ task:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-3_last-linux - name: hostonly_devicelab_tests-3_last-linux
only_if: "$CIRRUS_PR != '' || $CIRRUS_BRANCH == 'master'" # https://github.com/flutter/flutter/issues/45453
environment: environment:
# Some of the host-only devicelab tests are pretty involved and need a lot of RAM. # Some of the host-only devicelab tests are pretty involved and need a lot of RAM.
CPU: 2 CPU: 2
@ -399,22 +403,22 @@ task:
- dart --enable-asserts dev\bots\test.dart - dart --enable-asserts dev\bots\test.dart
- name: hostonly_devicelab_tests-0-windows - name: hostonly_devicelab_tests-0-windows
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-1-windows - name: hostonly_devicelab_tests-1-windows
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-2-windows - name: hostonly_devicelab_tests-2-windows
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-3_last-windows - name: hostonly_devicelab_tests-3_last-windows
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41941 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
@ -512,25 +516,25 @@ task:
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-0-macos - name: hostonly_devicelab_tests-0-macos
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41940 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976 - ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-1-macos - name: hostonly_devicelab_tests-1-macos
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41940 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976 - ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-2-macos - name: hostonly_devicelab_tests-2-macos
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41940 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976 - ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart
- name: hostonly_devicelab_tests-3_last-macos - name: hostonly_devicelab_tests-3_last-macos
only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || $CIRRUS_PR == ''" # https://github.com/flutter/flutter/issues/41940 only_if: "changesInclude('.cirrus.yml', 'dev/**', 'bin/internal/**') || ($CIRRUS_PR == '' && $CIRRUS_BRANCH == 'master')" # https://github.com/flutter/flutter/issues/41941 https://github.com/flutter/flutter/issues/45453
script: script:
- ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976 - ulimit -S -n 2048 # https://github.com/flutter/flutter/issues/2976
- dart --enable-asserts ./dev/bots/test.dart - dart --enable-asserts ./dev/bots/test.dart

20
dev/bots/test.dart
View File

@ -291,12 +291,20 @@ Future<void> _runBuildTests() async {
await _flutterBuildIpa(examplePath); await _flutterBuildIpa(examplePath);
} }
} }
// Web compilation tests.
await _flutterBuildDart2js(path.join('dev', 'integration_tests', 'web'), path.join('lib', 'main.dart')); final String branch = Platform.environment['CIRRUS_BRANCH'];
// Should not fail to compile with dart:io. if (branch != 'beta' && branch != 'stable') {
await _flutterBuildDart2js(path.join('dev', 'integration_tests', 'web_compile_tests'), // Web compilation tests.
path.join('lib', 'dart_io_import.dart'), await _flutterBuildDart2js(
); path.join('dev', 'integration_tests', 'web'),
path.join('lib', 'main.dart'),
);
// Should not fail to compile with dart:io.
await _flutterBuildDart2js(
path.join('dev', 'integration_tests', 'web_compile_tests'),
path.join('lib', 'dart_io_import.dart'),
);
}
} }
Future<void> _flutterBuildAot(String relativePathToApplication) async { Future<void> _flutterBuildAot(String relativePathToApplication) async {