<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> Feat: Added forceErrorText in DropdownButtonFormField #165188 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
This commit is contained in:
parent
0ab39c3278
commit
be627165df
@ -1731,6 +1731,7 @@ class DropdownButtonFormField<T> extends FormField<T> {
|
|||||||
super.onSaved,
|
super.onSaved,
|
||||||
super.validator,
|
super.validator,
|
||||||
super.errorBuilder,
|
super.errorBuilder,
|
||||||
|
super.forceErrorText,
|
||||||
AutovalidateMode? autovalidateMode,
|
AutovalidateMode? autovalidateMode,
|
||||||
double? menuMaxHeight,
|
double? menuMaxHeight,
|
||||||
bool? enableFeedback,
|
bool? enableFeedback,
|
||||||
|
@ -1294,4 +1294,92 @@ void main() {
|
|||||||
await tester.pumpWidget(buildFrame(alignedDropdown: true, textDirection: TextDirection.rtl));
|
await tester.pumpWidget(buildFrame(alignedDropdown: true, textDirection: TextDirection.rtl));
|
||||||
expect(tester.getRect(findSelectedValue), contentRectForUnalignedDropdown);
|
expect(tester.getRect(findSelectedValue), contentRectForUnalignedDropdown);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
testWidgets('isValid returns false when forceErrorText is set and changes error display', (
|
||||||
|
WidgetTester tester,
|
||||||
|
) async {
|
||||||
|
final GlobalKey<FormFieldState<String>> fieldKey1 = GlobalKey<FormFieldState<String>>();
|
||||||
|
final GlobalKey<FormFieldState<String>> fieldKey2 = GlobalKey<FormFieldState<String>>();
|
||||||
|
const String forceErrorText = 'Forcing error.';
|
||||||
|
await tester.pumpWidget(
|
||||||
|
MaterialApp(
|
||||||
|
home: MediaQuery(
|
||||||
|
data: const MediaQueryData(),
|
||||||
|
child: Directionality(
|
||||||
|
textDirection: TextDirection.ltr,
|
||||||
|
child: Center(
|
||||||
|
child: Material(
|
||||||
|
child: Form(
|
||||||
|
child: ListView(
|
||||||
|
children: <Widget>[
|
||||||
|
DropdownButtonFormField<String>(
|
||||||
|
key: fieldKey1,
|
||||||
|
items:
|
||||||
|
menuItems.map((String value) {
|
||||||
|
return DropdownMenuItem<String>(value: value, child: Text(value));
|
||||||
|
}).toList(),
|
||||||
|
onChanged: null,
|
||||||
|
autovalidateMode: AutovalidateMode.disabled,
|
||||||
|
),
|
||||||
|
DropdownButtonFormField<String>(
|
||||||
|
key: fieldKey2,
|
||||||
|
items:
|
||||||
|
menuItems.map((String value) {
|
||||||
|
return DropdownMenuItem<String>(value: value, child: Text(value));
|
||||||
|
}).toList(),
|
||||||
|
forceErrorText: forceErrorText,
|
||||||
|
onChanged: onChanged,
|
||||||
|
autovalidateMode: AutovalidateMode.disabled,
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(fieldKey1.currentState!.isValid, isTrue);
|
||||||
|
expect(fieldKey1.currentState!.hasError, isFalse);
|
||||||
|
expect(fieldKey2.currentState!.isValid, isFalse);
|
||||||
|
expect(fieldKey2.currentState!.hasError, isTrue);
|
||||||
|
});
|
||||||
|
|
||||||
|
testWidgets('forceErrorText overrides InputDecoration.error when both are provided', (
|
||||||
|
WidgetTester tester,
|
||||||
|
) async {
|
||||||
|
const String forceErrorText = 'Forcing error';
|
||||||
|
const String decorationErrorText = 'Decoration';
|
||||||
|
|
||||||
|
await tester.pumpWidget(
|
||||||
|
MaterialApp(
|
||||||
|
home: MediaQuery(
|
||||||
|
data: const MediaQueryData(),
|
||||||
|
child: Directionality(
|
||||||
|
textDirection: TextDirection.ltr,
|
||||||
|
child: Center(
|
||||||
|
child: Material(
|
||||||
|
child: Form(
|
||||||
|
child: DropdownButtonFormField<String>(
|
||||||
|
items:
|
||||||
|
menuItems.map<DropdownMenuItem<String>>((String value) {
|
||||||
|
return DropdownMenuItem<String>(value: value, child: Text(value));
|
||||||
|
}).toList(),
|
||||||
|
decoration: const InputDecoration(errorText: decorationErrorText),
|
||||||
|
forceErrorText: forceErrorText,
|
||||||
|
onChanged: null,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(find.text(forceErrorText), findsOne);
|
||||||
|
expect(find.text(decorationErrorText), findsNothing);
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user