firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove mention of directly landing on master (#11190)

Browse Source 
It's probably too much of a foot gun.

Also, emphasize what you have to do in case people didn't read the design principles document.
This commit is contained in:
Ian Hickson 2017-07-13 10:23:29 -07:00 committed by Michael Goderbauer
parent cb35a1c728
commit be9dd4b28e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
CONTRIBUTING.md
View File

@ -167,13 +167,15 @@ To send us a pull request:
Please make sure all your checkins have detailed commit messages explaining the patch. Please make sure all your checkins have detailed commit messages explaining the patch.
Once you've gotten an LGTM from a project maintainer, submit your changes to the Once you've gotten an LGTM from a project maintainer and once your PR has received
`master` branch using one of the following methods: the green light from all our automated testing (Travis, Appveyor, etc), and once
the tree is green (see the [design principles](https://flutter.io/design-principles/)
document for more details), submit your changes to the `master` branch using one of
the following methods:
* Wait for one of the project maintainers to submit it for you. * Wait for one of the project maintainers to submit it for you.
* Click the green "Merge pull request" button on the GitHub UI of your pull * Click the green "Merge pull request" button on the GitHub UI of your pull
request (requires commit access) request (requires commit access)
* `git push upstream name_of_your_branch:master` (requires commit access)
You must complete the You must complete the
[Contributor License Agreement](https://cla.developers.google.com/clas). [Contributor License Agreement](https://cla.developers.google.com/clas).