firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove null-safety argument from DartPad doc samples (#127345)

Browse Source 
Removes the `null_safety=true` query parameter from DartPad samples in the API docs, since all DartPad channels only support null safety now and the parameter does nothing.

## Test

Removing code, but updates the check in the dartdoc tool for the removal.
This commit is contained in:
Parker Lougheed 2023-05-22 19:10:11 -05:00 committed by GitHub
parent a6d62ca8de
commit c313083a88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/snippets/config/skeletons/dartpad-sample.html
View File

@ -13,7 +13,7 @@
</p> </p>
</div> </div>
<iframe class="snippet-dartpad" <iframe class="snippet-dartpad"
src="https://dartpad.dev/embed-flutter.html?split=60&amp;run=true&amp;null_safety=true&amp;sample_id={{id}}&amp;sample_channel={{channel}}&amp;channel={{channel}}"> src="https://dartpad.dev/embed-flutter.html?split=60&amp;run=true&amp;sample_id={{id}}&amp;sample_channel={{channel}}&amp;channel={{channel}}">
</iframe> </iframe>
</div> </div>
{@end-inject-html} {@end-inject-html}

1
dev/tools/dartdoc.dart
View File

@ -444,7 +444,6 @@ void sanityCheckDocs([Platform platform = const LocalPlatform()]) {
final List<String> argumentRegExps = <String>[ final List<String> argumentRegExps = <String>[
r'split=\d+', r'split=\d+',
r'run=true', r'run=true',
r'null_safety=true',
r'sample_id=widgets\.Listener\.\d+', r'sample_id=widgets\.Listener\.\d+',
'sample_channel=$expectedBranch', 'sample_channel=$expectedBranch',
'channel=$expectedBranch', 'channel=$expectedBranch',