firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

try lint avoid_unused_constructor_parameters (#13250)

Browse Source
This commit is contained in:
Alexandre Ardhuin 2017-11-30 09:20:53 +01:00 committed by GitHub
parent fcdbdfb476
commit c358898a76
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
analysis_options.yaml
View File

@ -70,7 +70,7 @@ linter:
# - avoid_setters_without_getters # not yet tested # - avoid_setters_without_getters # not yet tested
- avoid_slow_async_io - avoid_slow_async_io
# - avoid_types_on_closure_parameters # conflicts with always_specify_types # - avoid_types_on_closure_parameters # conflicts with always_specify_types
# - avoid_unused_constructor_parameters # not yet tested # - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847
- await_only_futures - await_only_futures
- camel_case_types - camel_case_types
- cancel_subscriptions - cancel_subscriptions

2
analysis_options_repo.yaml
View File

@ -63,7 +63,7 @@ linter:
# - avoid_setters_without_getters # not yet tested # - avoid_setters_without_getters # not yet tested
- avoid_slow_async_io - avoid_slow_async_io
# - avoid_types_on_closure_parameters # conflicts with always_specify_types # - avoid_types_on_closure_parameters # conflicts with always_specify_types
# - avoid_unused_constructor_parameters # not yet tested # - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847
- await_only_futures - await_only_futures
- camel_case_types - camel_case_types
- cancel_subscriptions - cancel_subscriptions

1
packages/flutter/lib/src/foundation/diagnostics.dart
View File

@ -1955,7 +1955,6 @@ class DiagnosticableNode<T extends Diagnosticable> extends DiagnosticsNode {
String name, String name,
@required this.value, @required this.value,
@required DiagnosticsTreeStyle style, @required DiagnosticsTreeStyle style,
String emptyBodyDescription,
}) : assert(value != null), }) : assert(value != null),
super( super(
name: name, name: name,

1
packages/flutter/lib/src/rendering/editable.dart
View File

@ -127,6 +127,7 @@ class RenderEditable extends RenderBox {
_showCursor = showCursor ?? new ValueNotifier<bool>(false), _showCursor = showCursor ?? new ValueNotifier<bool>(false),
_hasFocus = hasFocus ?? false, _hasFocus = hasFocus ?? false,
_maxLines = maxLines, _maxLines = maxLines,
_selectionColor = selectionColor,
_selection = selection, _selection = selection,
_offset = offset { _offset = offset {
assert(_showCursor != null); assert(_showCursor != null);