firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reverts "[Impeller] Make impeller goldens test blocking. (#143864)" (#143896)

Browse Source 
Reverts flutter/flutter#143864

Initiated by: goderbauer

Reason for reverting: The test is consistently failing in post-submit, e.g. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755443299639610049/+/u/run_test.dart_for_framework_tests_shard_and_subshard_impeller/stdout

Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.
This commit is contained in:
auto-submit[bot] 2024-02-21 23:23:22 +00:00 committed by GitHub
parent 0be6668418
commit c3e786f3f3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.ci.yaml
View File

@ -3460,6 +3460,7 @@ targets:
- name: Mac framework_tests_impeller - name: Mac framework_tests_impeller
recipe: flutter/flutter_drone recipe: flutter/flutter_drone
timeout: 60 timeout: 60
bringup: true
properties: properties:
cpu: x86 # https://github.com/flutter/flutter/issues/119880 cpu: x86 # https://github.com/flutter/flutter/issues/119880
dependencies: >- dependencies: >-