firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3329 from alhaad/repaint_childview

Browse Source 
Repaint child view on attach / detach.
This commit is contained in:
Alhaad Gokhale 2016-04-13 20:26:52 -07:00
commit c40f4cfedb
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/flutter/lib/src/rendering/child_view.dart
View File

@ -124,8 +124,8 @@ class ChildViewConnection {
assert(_attached); assert(_attached);
assert(_viewOwner != null); assert(_viewOwner != null);
assert(_viewKey == null); assert(_viewKey == null);
assert(_viewInfo == null);
_viewKey = _nextViewKey++; _viewKey = _nextViewKey++;
_viewInfo = null;
_viewContainer?.addChild(_viewKey, _viewOwner.impl); _viewContainer?.addChild(_viewKey, _viewOwner.impl);
_viewOwner = null; _viewOwner = null;
assert(!_ViewContainerListenerImpl.instance._connections.containsKey(_viewKey)); assert(!_ViewContainerListenerImpl.instance._connections.containsKey(_viewKey));
@ -253,12 +253,20 @@ class RenderChildView extends RenderBox {
@override @override
void attach(PipelineOwner owner) { void attach(PipelineOwner owner) {
super.attach(owner); super.attach(owner);
_child?._attach(); if (_child != null) {
_child._attach();
assert(_child._onViewInfoAvailable == null);
_child._onViewInfoAvailable = markNeedsPaint;
}
} }
@override @override
void detach() { void detach() {
_child?._detach(); if (_child != null) {
_child._detach();
assert(_child._onViewInfoAvailable != null);
_child._onViewInfoAvailable = null;
}
super.detach(); super.detach();
} }