firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove RouteSetting.copyWith (#113860)

Browse Source
This commit is contained in:
chunhtai 2022-10-27 15:09:05 -07:00 committed by GitHub
parent f60b44dae5
commit c6f6095acd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter/lib/src/widgets/navigator.dart
View File

@ -537,18 +537,6 @@ class RouteSettings {
this.arguments, this.arguments,
}); });
/// Creates a copy of this route settings object with the given fields
/// replaced with the new values.
RouteSettings copyWith({
String? name,
Object? arguments,
}) {
return RouteSettings(
name: name ?? this.name,
arguments: arguments ?? this.arguments,
);
}
/// The name of the route (e.g., "/settings"). /// The name of the route (e.g., "/settings").
/// ///
/// If null, the route is anonymous. /// If null, the route is anonymous.

10
packages/flutter/test/widgets/routes_test.dart
View File

@ -116,8 +116,6 @@ void main() {
testWidgets('Route settings', (WidgetTester tester) async { testWidgets('Route settings', (WidgetTester tester) async {
const RouteSettings settings = RouteSettings(name: 'A'); const RouteSettings settings = RouteSettings(name: 'A');
expect(settings, hasOneLineDescription); expect(settings, hasOneLineDescription);
final RouteSettings settings2 = settings.copyWith(name: 'B');
expect(settings2.name, 'B');
}); });
testWidgets('Route settings arguments', (WidgetTester tester) async { testWidgets('Route settings arguments', (WidgetTester tester) async {
@ -127,14 +125,6 @@ void main() {
final Object arguments = Object(); final Object arguments = Object();
final RouteSettings settings2 = RouteSettings(name: 'A', arguments: arguments); final RouteSettings settings2 = RouteSettings(name: 'A', arguments: arguments);
expect(settings2.arguments, same(arguments)); expect(settings2.arguments, same(arguments));
final RouteSettings settings3 = settings2.copyWith();
expect(settings3.arguments, equals(arguments));
final Object arguments2 = Object();
final RouteSettings settings4 = settings2.copyWith(arguments: arguments2);
expect(settings4.arguments, same(arguments2));
expect(settings4.arguments, isNot(same(arguments)));
}); });
testWidgets('Route management - push, replace, pop sequence', (WidgetTester tester) async { testWidgets('Route management - push, replace, pop sequence', (WidgetTester tester) async {