From c6f997085c04f6c81f0f80034b6e0152185cdb4e Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Tue, 24 Feb 2015 17:20:18 -0800 Subject: [PATCH] Make splash animations abort on scroll. I also fixed the transform hack in material-element to clean up after itself. I also discovered that our namedSetter implementation did not handle null (it crashed) while doing this. I fixed that and tested my fix. This runs great on a Nexus 5, but poorly on an Nexus 10. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/956753002 --- .../styles/inline-style-crash-expected.txt | 6 ++++ .../tests/styles/inline-style-crash.sky | 28 +++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 engine/src/flutter/tests/styles/inline-style-crash-expected.txt create mode 100644 engine/src/flutter/tests/styles/inline-style-crash.sky diff --git a/engine/src/flutter/tests/styles/inline-style-crash-expected.txt b/engine/src/flutter/tests/styles/inline-style-crash-expected.txt new file mode 100644 index 0000000000..ba9894dd32 --- /dev/null +++ b/engine/src/flutter/tests/styles/inline-style-crash-expected.txt @@ -0,0 +1,6 @@ +CONSOLE: unittest-suite-wait-for-done +CONSOLE: PASS: should not crash when setting style to null +CONSOLE: +CONSOLE: All 1 tests passed. +CONSOLE: unittest-suite-success +DONE diff --git a/engine/src/flutter/tests/styles/inline-style-crash.sky b/engine/src/flutter/tests/styles/inline-style-crash.sky new file mode 100644 index 0000000000..9a017c79b9 --- /dev/null +++ b/engine/src/flutter/tests/styles/inline-style-crash.sky @@ -0,0 +1,28 @@ + + + +