firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RTL InputDecoration fix (#129661)

Browse Source 
Fixes InputDecoration (TextField) layout when 1. RTL 2. prefixIcon and 3. left/right contentPadding is asymmetric.
This commit is contained in:
Justin McCandless 2023-06-28 16:31:51 -07:00 committed by GitHub
parent c1b764a80f
commit c7511664e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/input_decorator.dart
View File

@ -1410,7 +1410,7 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
double start = right - _boxSize(icon).width;
double end = left;
if (prefixIcon != null) {
start += contentPadding.left;
start += contentPadding.right;
start -= centerLayout(prefixIcon!, start - prefixIcon!.size.width);
}
if (label != null) {

30
packages/flutter/test/material/input_decorator_test.dart
View File

@ -6516,5 +6516,35 @@ void main() {
final Text hintTextWidget = tester.widget(hintTextFinder);
expect(hintTextWidget.style!.overflow, decoration.hintStyle!.overflow);
});
testWidgets('prefixIcon in RTL with asymmetric padding', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/129591
const InputDecoration decoration = InputDecoration(
contentPadding: EdgeInsetsDirectional.only(end: 24),
prefixIcon: Focus(child: Icon(Icons.search)),
);
await tester.pumpWidget(
buildInputDecorator(
useMaterial3: useMaterial3,
// isEmpty: false (default)
// isFocused: false (default)
decoration: decoration,
textDirection: TextDirection.rtl,
),
);
await tester.pumpAndSettle();
expect(find.byType(InputDecorator), findsOneWidget);
expect(find.byType(Icon), findsOneWidget);
final Offset(dx: double decoratorRight) =
tester.getTopRight(find.byType(InputDecorator));
final Offset(dx: double prefixRight) =
tester.getTopRight(find.byType(Icon));
// The prefix is inside the decorator.
expect(decoratorRight, lessThanOrEqualTo(prefixRight));
});
}
}