firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove RepaintBoundary that is no longer needed. (#159232)

Browse Source 
Closes https://github.com/flutter/flutter/issues/66006.

From what I can tell in the multi-view effort a variation of
https://github.com/flutter/flutter/pull/88609 already landed, meaning
that the current device-pixel-ratio is being used (as the tests in
#88609 are now passing), and I believe that means we can remove the
override/hack.

Will rely on "Google Testing" to run a TGP internally, or do so myself
if necessary.
This commit is contained in:
Matan Lurey 2024-11-21 09:50:46 -08:00 committed by GitHub
parent d1e2c5fba7
commit c7dd6419d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_test/test/bindings_test.dart
View File

@ -30,6 +30,11 @@ void main() {
final Matrix4 matrix = TestViewConfiguration(size: Size.zero).toMatrix();
expect(matrix.storage.every((double x) => x.isFinite), isTrue);
});
test('sets the DPR to match the window', () {
final TestViewConfiguration configuration = TestViewConfiguration(size: const Size(1280.0, 800.0));
expect(configuration.devicePixelRatio, binding.window.devicePixelRatio);
});
});
group(AutomatedTestWidgetsFlutterBinding, () {

8
packages/integration_test/lib/integration_test.dart
View File

@ -446,14 +446,6 @@ https://docs.flutter.dev/testing/integration-tests
@override
Timeout defaultTestTimeout = Timeout.none;
@override
Widget wrapWithDefaultView(Widget rootWidget) {
// This is a workaround where screenshots of root widgets have incorrect
// bounds.
// TODO(jiahaog): Remove when https://github.com/flutter/flutter/issues/66006 is fixed.
return super.wrapWithDefaultView(RepaintBoundary(child: rootWidget));
}
@override
void reportExceptionNoticed(FlutterErrorDetails exception) {
// This method is called to log errors as they happen, and they will also

6
packages/integration_test/test/binding_test.dart
View File

@ -124,11 +124,11 @@ Future<void> main() async {
});
});
// TODO(jiahaog): Remove when https://github.com/flutter/flutter/issues/66006 is fixed.
testWidgets('root widgets are wrapped with a RepaintBoundary', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/66006.
testWidgets('root view reports correct dimensions', (WidgetTester tester) async {
await tester.pumpWidget(const Placeholder());
expect(find.byType(RepaintBoundary), findsOneWidget);
expect(tester.binding.renderView.paintBounds, const Rect.fromLTWH(0, 0, 2400, 1800));
});
testWidgets('integration test has no label', (WidgetTester tester) async {