firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory leak in data table (#146892)

Browse Source
This commit is contained in:
Valentin Vignal 2024-04-18 22:16:32 +08:00 committed by GitHub
parent 47a4c69b82
commit c83d650de4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/test/material/data_table_theme_test.dart
View File

@ -6,6 +6,7 @@ import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart'; import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
void main() { void main() {
test('DataTableThemeData copyWith, ==, hashCode basics', () { test('DataTableThemeData copyWith, ==, hashCode basics', () {
@ -552,7 +553,10 @@ void main() {
}); });
// This is a regression test for https://github.com/flutter/flutter/issues/143340. // This is a regression test for https://github.com/flutter/flutter/issues/143340.
testWidgets('DataColumn label can be centered with DataTableTheme.headingRowAlignment', (WidgetTester tester) async { testWidgets('DataColumn label can be centered with DataTableTheme.headingRowAlignment',
// TODO(polina-c): remove when fixed https://github.com/flutter/flutter/issues/145600 [leak-tracking-opt-in]
experimentalLeakTesting: LeakTesting.settings.withTracked(classes: const <String>['CurvedAnimation']),
(WidgetTester tester) async {
const double horizontalMargin = 24.0; const double horizontalMargin = 24.0;
Widget buildTable({ MainAxisAlignment? headingRowAlignment, bool sortEnabled = false }) { Widget buildTable({ MainAxisAlignment? headingRowAlignment, bool sortEnabled = false }) {