Add empty io.flutter.app.FlutterApplication
to give deprecation notice, and un-break projects that have not migrated (#164233)
The removal of the v1 embedding missed that this class was not marked as deprecated, and did not provide a notice in the breaking changes section. V1 apps that needed the functionality of the old `FlutterApplication` were all broken in the previous release, but some V2 apps have been referencing the v1 `FlutterApplication`. For these apps, this is the same as extending the base `android.app.Application`. So we can provide an "empty extension" of that base class, to provide these v2 apps a deprecation notice, and avoid breaking them without warning (in 3.29.1). Arbitrarily chose the `spell_checker` integration test to reference this empty application, let me know if you think I should bring up an entirely new devicelab test instead. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
This commit is contained in:
parent
6ec7ae3a1c
commit
c9c3e74747
@ -18,6 +18,9 @@
|
|||||||
<file name="dev/integration_tests/spell_check/android/app/src/main/kotlin/com/example/sc_int_test/MainActivity.kt">
|
<file name="dev/integration_tests/spell_check/android/app/src/main/kotlin/com/example/sc_int_test/MainActivity.kt">
|
||||||
<error line="1" column="9" source="standard:package-name" />
|
<error line="1" column="9" source="standard:package-name" />
|
||||||
</file>
|
</file>
|
||||||
|
<file name="dev/integration_tests/spell_check/android/app/src/main/kotlin/com/example/sc_int_test/MainApplication.kt">
|
||||||
|
<error line="5" column="9" source="standard:package-name" />
|
||||||
|
</file>
|
||||||
<file name="dev/manual_tests/android/app/src/main/kotlin/dev/flutter/manual_tests/MainActivity.kt">
|
<file name="dev/manual_tests/android/app/src/main/kotlin/dev/flutter/manual_tests/MainActivity.kt">
|
||||||
<error line="1" column="9" source="standard:package-name" />
|
<error line="1" column="9" source="standard:package-name" />
|
||||||
</file>
|
</file>
|
||||||
|
@ -5,7 +5,7 @@ found in the LICENSE file. -->
|
|||||||
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
|
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
|
||||||
<application
|
<application
|
||||||
android:label="spell_check"
|
android:label="spell_check"
|
||||||
android:name="${applicationName}"
|
android:name="com.example.spell_check.MainApplication"
|
||||||
android:icon="@mipmap/ic_launcher">
|
android:icon="@mipmap/ic_launcher">
|
||||||
<activity
|
<activity
|
||||||
android:name=".MainActivity"
|
android:name=".MainActivity"
|
||||||
|
@ -0,0 +1,12 @@
|
|||||||
|
// Copyright 2014 The Flutter Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style license that can be
|
||||||
|
// found in the LICENSE file.
|
||||||
|
|
||||||
|
package com.example.spell_check
|
||||||
|
|
||||||
|
import io.flutter.app.FlutterApplication
|
||||||
|
|
||||||
|
// The spell check application was arbitrarily chosen to also test the ability
|
||||||
|
// to extend `io.flutter.app.FlutterApplication`. This should be removed when the
|
||||||
|
// class itself is removed.
|
||||||
|
class MainApplication : FlutterApplication()
|
@ -43000,6 +43000,7 @@ ORIGIN: ../../../flutter/shell/platform/android/io/flutter/Build.java + ../../..
|
|||||||
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/BuildConfig.java + ../../../flutter/LICENSE
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/BuildConfig.java + ../../../flutter/LICENSE
|
||||||
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/FlutterInjector.java + ../../../flutter/LICENSE
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/FlutterInjector.java + ../../../flutter/LICENSE
|
||||||
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/Log.java + ../../../flutter/LICENSE
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/Log.java + ../../../flutter/LICENSE
|
||||||
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/app/FlutterApplication.java + ../../../flutter/LICENSE
|
||||||
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/android/ExclusiveAppComponent.java + ../../../flutter/LICENSE
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/android/ExclusiveAppComponent.java + ../../../flutter/LICENSE
|
||||||
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java + ../../../flutter/LICENSE
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java + ../../../flutter/LICENSE
|
||||||
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java + ../../../flutter/LICENSE
|
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java + ../../../flutter/LICENSE
|
||||||
@ -45923,6 +45924,7 @@ FILE: ../../../flutter/shell/platform/android/io/flutter/Build.java
|
|||||||
FILE: ../../../flutter/shell/platform/android/io/flutter/BuildConfig.java
|
FILE: ../../../flutter/shell/platform/android/io/flutter/BuildConfig.java
|
||||||
FILE: ../../../flutter/shell/platform/android/io/flutter/FlutterInjector.java
|
FILE: ../../../flutter/shell/platform/android/io/flutter/FlutterInjector.java
|
||||||
FILE: ../../../flutter/shell/platform/android/io/flutter/Log.java
|
FILE: ../../../flutter/shell/platform/android/io/flutter/Log.java
|
||||||
|
FILE: ../../../flutter/shell/platform/android/io/flutter/app/FlutterApplication.java
|
||||||
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java
|
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java
|
||||||
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/ExclusiveAppComponent.java
|
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/ExclusiveAppComponent.java
|
||||||
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java
|
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java
|
||||||
|
@ -207,6 +207,7 @@ android_java_sources = [
|
|||||||
"io/flutter/Build.java",
|
"io/flutter/Build.java",
|
||||||
"io/flutter/FlutterInjector.java",
|
"io/flutter/FlutterInjector.java",
|
||||||
"io/flutter/Log.java",
|
"io/flutter/Log.java",
|
||||||
|
"io/flutter/app/FlutterApplication.java",
|
||||||
"io/flutter/embedding/android/AndroidTouchProcessor.java",
|
"io/flutter/embedding/android/AndroidTouchProcessor.java",
|
||||||
"io/flutter/embedding/android/ExclusiveAppComponent.java",
|
"io/flutter/embedding/android/ExclusiveAppComponent.java",
|
||||||
"io/flutter/embedding/android/FlutterActivity.java",
|
"io/flutter/embedding/android/FlutterActivity.java",
|
||||||
|
@ -0,0 +1,18 @@
|
|||||||
|
// Copyright 2013 The Flutter Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style license that can be
|
||||||
|
// found in the LICENSE file.
|
||||||
|
|
||||||
|
package io.flutter.app;
|
||||||
|
|
||||||
|
import android.app.Application;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Empty implementation of the {@link Application} class, provided to avoid breaking older Flutter
|
||||||
|
* projects. Flutter projects which need to extend an Application should migrate to extending {@link
|
||||||
|
* android.app.Application} instead.
|
||||||
|
*
|
||||||
|
* <p>For more information on the removal of Flutter's v1 Android embedding, see:
|
||||||
|
* https://docs.flutter.dev/release/breaking-changes/v1-android-embedding.
|
||||||
|
*/
|
||||||
|
@Deprecated
|
||||||
|
public class FlutterApplication extends Application {}
|
@ -66,6 +66,7 @@ def main():
|
|||||||
classpath.append(args.build_config_path)
|
classpath.append(args.build_config_path)
|
||||||
|
|
||||||
packages = [
|
packages = [
|
||||||
|
'io.flutter.app',
|
||||||
'io.flutter.embedding.android',
|
'io.flutter.embedding.android',
|
||||||
'io.flutter.embedding.engine',
|
'io.flutter.embedding.engine',
|
||||||
'io.flutter.embedding.engine.dart',
|
'io.flutter.embedding.engine.dart',
|
||||||
|
Loading…
x
Reference in New Issue
Block a user