From c9ee9ad6165f6aa232ffe579c2ea95586a46500a Mon Sep 17 00:00:00 2001 From: Polina Cherkasova Date: Mon, 22 Jul 2024 09:53:40 -0700 Subject: [PATCH] Clean up leaky test. (#152094) --- .../flutter/test/material/carousel_test.dart | 21 ++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/packages/flutter/test/material/carousel_test.dart b/packages/flutter/test/material/carousel_test.dart index b47a560cca..3754711935 100644 --- a/packages/flutter/test/material/carousel_test.dart +++ b/packages/flutter/test/material/carousel_test.dart @@ -256,11 +256,14 @@ void main() { }); testWidgets('CarouselController initialItem', (WidgetTester tester) async { + final CarouselController controller = CarouselController(initialItem: 5); + addTearDown(controller.dispose); + await tester.pumpWidget( MaterialApp( home: Scaffold( body: CarouselView( - controller: CarouselController(initialItem: 5), + controller: controller, itemExtent: 400, children: List.generate(10, (int index) { return Center( @@ -290,11 +293,14 @@ void main() { }); testWidgets('CarouselView.weighted respects CarouselController.initialItem', (WidgetTester tester) async { + final CarouselController controller = CarouselController(initialItem: 5); + addTearDown(controller.dispose); + await tester.pumpWidget( MaterialApp( home: Scaffold( body: CarouselView.weighted( - controller: CarouselController(initialItem: 5), + controller: controller, flexWeights: const [7, 1], children: List.generate(10, (int index) { return Center( @@ -324,11 +330,14 @@ void main() { }); testWidgets('The initialItem should be the first item with expanded size(max extent)', (WidgetTester tester) async { + final CarouselController controller = CarouselController(initialItem: 5); + addTearDown(controller.dispose); + await tester.pumpWidget( MaterialApp( home: Scaffold( body: CarouselView.weighted( - controller: CarouselController(initialItem: 5), + controller: controller, flexWeights: const [1, 8, 1], children: List.generate(10, (int index) { return Center( @@ -945,6 +954,8 @@ void main() { testWidgets('The initialItem stays when the flexWeights is updated', (WidgetTester tester) async { final CarouselController controller = CarouselController(initialItem: 3); + addTearDown(controller.dispose); + Widget buildCarousel(List flexWeights) { return MaterialApp( home: Scaffold( @@ -991,6 +1002,8 @@ void main() { testWidgets('The item that currently occupies max weight stays when the flexWeights is updated', (WidgetTester tester) async { final CarouselController controller = CarouselController(initialItem: 3); + addTearDown(controller.dispose); + Widget buildCarousel(List flexWeights) { return MaterialApp( home: Scaffold( @@ -1038,6 +1051,8 @@ void main() { testWidgets('The initialItem stays when the itemExtent is updated', (WidgetTester tester) async { final CarouselController controller = CarouselController(initialItem: 3); + addTearDown(controller.dispose); + Widget buildCarousel(double itemExtent) { return MaterialApp( home: Scaffold(