firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use StyleNode in StockMenu

Browse Source 
StockMenu was creating a container for the sole purpose of applying style to
PopupMenu. Now we just use a StyleNode.

Also, I've reverted the change to make box-sizing default to border-box. It
turns out that CL wasn't effective because we didn't use the initialBoxSizing
function to initialize box sizing. I've made us use initialBoxSizing but switch
the default back to content-box because actually using border-box breaks a
bunch of stuff.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1024083003
This commit is contained in:
Adam Barth 2015-03-20 10:16:24 -07:00
parent f65ff7f4e5
commit ca74c312f7
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
examples/stocks-fn/lib/stock_menu.dart
View File

@ -17,9 +17,7 @@ class StockMenu extends Component {
StockMenu({Object key, this.controller}) : super(key: key); StockMenu({Object key, this.controller}) : super(key: key);
Node build() { Node build() {
return new Container( return new StyleNode(
style: _style,
children: [
new PopupMenu( new PopupMenu(
controller: controller, controller: controller,
items: [ items: [
@ -27,8 +25,8 @@ class StockMenu extends Component {
[new Text('Remove stock')], [new Text('Remove stock')],
[new Text('Help & feeback')], [new Text('Help & feeback')],
], ],
level: 4) level: 4),
] _style
); );
} }
} }