firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Gold json for digest paramset (#64757)

Browse Source
This commit is contained in:
Kate Lovett 2020-08-27 17:48:05 -07:00 committed by GitHub
parent 5a4fa220e2
commit cad4d1333e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_goldens/test/json_templates.dart
View File

@ -168,7 +168,7 @@ String digestResponseTemplate({
"status": "positive", "status": "positive",
"paramset": { "paramset": {
"Platform": [ "Platform": [
"macos" "$platform"
], ],
"ext": [ "ext": [
"png" "png"

4
packages/flutter_goldens_client/lib/skia_client.dart
View File

@ -687,7 +687,9 @@ class SkiaGoldDigest {
factory SkiaGoldDigest.fromJson(Map<String, dynamic> json) { factory SkiaGoldDigest.fromJson(Map<String, dynamic> json) {
return SkiaGoldDigest( return SkiaGoldDigest(
imageHash: json['digest'] as String, imageHash: json['digest'] as String,
paramSet: Map<String, dynamic>.from(json['paramset'] as Map<String, dynamic>? ?? paramSet:
Map<String, dynamic>.from(
json['refDiffs']['pos']['paramset'] as Map<String, dynamic>? ??
<String, List<String>>{ <String, List<String>>{
'Platform': <String>[], 'Platform': <String>[],
'Browser' : <String>[], 'Browser' : <String>[],