firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove dependency on web_tests/artifacts. (#160700)

Browse Source 
We no longer pass `web_tests/artifacts` via CAS, so we need to remove it
as a dependency.
This commit is contained in:
Jackson Gardner 2024-12-21 19:20:53 -08:00 committed by GitHub
parent 5e8b6247d2
commit cb40d94055
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
engine/src/flutter/ci/builders/linux_web_engine_test.json
View File

@ -193,18 +193,14 @@
"parameters": [ "parameters": [
"check-licenses" "check-licenses"
], ],
"scripts": [ "script": "flutter/lib/web_ui/dev/felt"
"flutter/lib/web_ui/dev/felt"
]
}, },
{ {
"name": "web engine analysis", "name": "web engine analysis",
"parameters": [ "parameters": [
"analyze" "analyze"
], ],
"scripts": [ "script": "flutter/lib/web_ui/dev/felt"
"flutter/lib/web_ui/dev/felt"
]
} }
] ]
}, },
@ -220,7 +216,6 @@
"download_jdk": false "download_jdk": false
}, },
"dependencies": [ "dependencies": [
"web_tests/artifacts",
"web_tests/test_bundles/dart2js-html-html", "web_tests/test_bundles/dart2js-html-html",
"web_tests/test_bundles/dart2js-html-ui", "web_tests/test_bundles/dart2js-html-ui",
"web_tests/test_bundles/dart2js-canvaskit-engine", "web_tests/test_bundles/dart2js-canvaskit-engine",
@ -412,7 +407,6 @@
"download_jdk": false "download_jdk": false
}, },
"dependencies": [ "dependencies": [
"web_tests/artifacts",
"web_tests/test_bundles/dart2js-html-html", "web_tests/test_bundles/dart2js-html-html",
"web_tests/test_bundles/dart2js-html-ui", "web_tests/test_bundles/dart2js-html-ui",
"web_tests/test_bundles/dart2js-canvaskit-engine", "web_tests/test_bundles/dart2js-canvaskit-engine",
@ -540,7 +534,6 @@
"download_jdk": false "download_jdk": false
}, },
"dependencies": [ "dependencies": [
"web_tests/artifacts",
"web_tests/test_bundles/dart2js-html-html", "web_tests/test_bundles/dart2js-html-html",
"web_tests/test_bundles/dart2js-html-ui", "web_tests/test_bundles/dart2js-html-ui",
"web_tests/test_bundles/dart2js-canvaskit-engine", "web_tests/test_bundles/dart2js-canvaskit-engine",

9
engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart
View File

@ -115,12 +115,12 @@ class GenerateBuilderJsonCommand extends Command<bool> {
<String, dynamic>{ <String, dynamic>{
'name': 'check licenses', 'name': 'check licenses',
'parameters': <String>['check-licenses'], 'parameters': <String>['check-licenses'],
'scripts': <String>['flutter/lib/web_ui/dev/felt'], 'script': 'flutter/lib/web_ui/dev/felt',
}, },
<String, dynamic>{ <String, dynamic>{
'name': 'web engine analysis', 'name': 'web engine analysis',
'parameters': <String>['analyze'], 'parameters': <String>['analyze'],
'scripts': <String>['flutter/lib/web_ui/dev/felt'], 'script': 'flutter/lib/web_ui/dev/felt',
}, },
], ],
}; };
@ -161,10 +161,7 @@ class GenerateBuilderJsonCommand extends Command<bool> {
if (cpu != null) 'cpu=$cpu', if (cpu != null) 'cpu=$cpu',
], ],
'gclient_variables': <String, dynamic>{'download_android_deps': false, 'download_jdk': false}, 'gclient_variables': <String, dynamic>{'download_android_deps': false, 'download_jdk': false},
'dependencies': <String>[ 'dependencies': <String>[...bundles.map((bundle) => 'web_tests/test_bundles/${bundle.name}')],
'web_tests/artifacts',
...bundles.map((bundle) => 'web_tests/test_bundles/${bundle.name}'),
],
'test_dependencies': <dynamic>[ 'test_dependencies': <dynamic>[
<String, dynamic>{ <String, dynamic>{
'dependency': 'goldctl', 'dependency': 'goldctl',