From cbc121e3929d7aaa75bad29bea69aca05a073420 Mon Sep 17 00:00:00 2001 From: Kate Lovett Date: Wed, 22 Apr 2020 16:33:01 -0700 Subject: [PATCH] ToDo Audit - Cupertino+ Library (#54798) --- dev/tools/dartdoc.dart | 6 +----- dev/tracing_tests/test/image_cache_tracing_test.dart | 2 +- examples/catalog/test/custom_semantics_test.dart | 5 +---- packages/flutter/lib/src/cupertino/action_sheet.dart | 6 ++++-- packages/flutter/lib/src/cupertino/context_menu.dart | 4 ++-- packages/flutter/lib/src/cupertino/dialog.dart | 6 ++++-- 6 files changed, 13 insertions(+), 16 deletions(-) diff --git a/dev/tools/dartdoc.dart b/dev/tools/dartdoc.dart index de2f59e8ac..7c1099c429 100644 --- a/dev/tools/dartdoc.dart +++ b/dev/tools/dartdoc.dart @@ -50,11 +50,7 @@ Future main(List arguments) async { final StringBuffer buf = StringBuffer(); buf.writeln('name: Flutter'); buf.writeln('homepage: https://flutter.dev'); - // TODO(dnfield): We should make DartDoc able to avoid emitting this. If we - // use the real value here, every file will get marked as new instead of only - // files that have otherwise changed. Instead, we replace it dynamically using - // JavaScript so that fewer files get marked as changed. - // https://github.com/dart-lang/dartdoc/issues/1982 + // TODO(dnfield): Re-factor for proper versioning, https://github.com/flutter/flutter/issues/55409 buf.writeln('version: 0.0.0'); buf.writeln('dependencies:'); for (final String package in findPackageNames()) { diff --git a/dev/tracing_tests/test/image_cache_tracing_test.dart b/dev/tracing_tests/test/image_cache_tracing_test.dart index 6eac37689e..e808dd0bd1 100644 --- a/dev/tracing_tests/test/image_cache_tracing_test.dart +++ b/dev/tracing_tests/test/image_cache_tracing_test.dart @@ -99,7 +99,7 @@ bool _mapsEqual(Map expectedArgs, Map args) { return true; } -// TODO(dnfield): we can drop this in favor of vm_service when https://github.com/dart-lang/webdev/issues/899 is resolved. +// TODO(dnfield): This can be removed in favor of using the vm_service package, https://github.com/flutter/flutter/issues/55411 class TimelineObtainer { WebSocket _observatorySocket; int _lastCallId = 0; diff --git a/examples/catalog/test/custom_semantics_test.dart b/examples/catalog/test/custom_semantics_test.dart index 329117b860..dd8217679d 100644 --- a/examples/catalog/test/custom_semantics_test.dart +++ b/examples/catalog/test/custom_semantics_test.dart @@ -18,10 +18,7 @@ void main() { await tester.pump(); // Verify it correctly exposes its semantics. - // TODO(goderbauer): Use `SemanticsTester` after https://github.com/flutter/flutter/issues/12286. - final SemanticsNode semantics = tester - .renderObject(find.byType(AdjustableDropdownListTile)) - .debugSemantics; + final SemanticsNode semantics = tester.getSemantics(find.byType(AdjustableDropdownListTile)); expectAdjustable(semantics, hasIncreaseAction: true, diff --git a/packages/flutter/lib/src/cupertino/action_sheet.dart b/packages/flutter/lib/src/cupertino/action_sheet.dart index bb57b25ed8..c025812236 100644 --- a/packages/flutter/lib/src/cupertino/action_sheet.dart +++ b/packages/flutter/lib/src/cupertino/action_sheet.dart @@ -937,13 +937,15 @@ class _PressableActionButtonState extends State<_PressableActionButton> { Widget build(BuildContext context) { return _ActionButtonParentDataWidget( isPressed: _isPressed, - // TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786 + // TODO(mattcarroll): Button press dynamics need overhaul for iOS: + // https://github.com/flutter/flutter/issues/19786 child: GestureDetector( excludeFromSemantics: true, behavior: HitTestBehavior.opaque, onTapDown: (TapDownDetails details) => setState(() => _isPressed = true), onTapUp: (TapUpDetails details) => setState(() => _isPressed = false), - // TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783 + // TODO(mattcarroll): Cancel is currently triggered when user moves past + // slop instead of off button: https://github.com/flutter/flutter/issues/19783 onTapCancel: () => setState(() => _isPressed = false), child: widget.child, ), diff --git a/packages/flutter/lib/src/cupertino/context_menu.dart b/packages/flutter/lib/src/cupertino/context_menu.dart index 68d462e3d7..68f3089d1e 100644 --- a/packages/flutter/lib/src/cupertino/context_menu.dart +++ b/packages/flutter/lib/src/cupertino/context_menu.dart @@ -378,8 +378,8 @@ class _CupertinoContextMenuState extends State with Ticker // decoy will pop on top of the AppBar if the child is partially behind it, // such as a top item in a partially scrolled view. However, if we don't use // an overlay, then the decoy will appear behind its neighboring widget when - // it expands. This may be solveable by adding a widget to Scaffold that's - // undernearth the AppBar. + // it expands. This may be solvable by adding a widget to Scaffold that's + // underneath the AppBar. _lastOverlayEntry = OverlayEntry( opaque: false, builder: (BuildContext context) { diff --git a/packages/flutter/lib/src/cupertino/dialog.dart b/packages/flutter/lib/src/cupertino/dialog.dart index 3623fc0cab..15854603ff 100644 --- a/packages/flutter/lib/src/cupertino/dialog.dart +++ b/packages/flutter/lib/src/cupertino/dialog.dart @@ -995,7 +995,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> { return _ActionButtonParentDataWidget( isPressed: _isPressed, child: MergeSemantics( - // TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786 + // TODO(mattcarroll): Button press dynamics need overhaul for iOS: + // https://github.com/flutter/flutter/issues/19786 child: GestureDetector( excludeFromSemantics: true, behavior: HitTestBehavior.opaque, @@ -1005,7 +1006,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> { onTapUp: (TapUpDetails details) => setState(() { _isPressed = false; }), - // TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783 + // TODO(mattcarroll): Cancel is currently triggered when user moves + // past slop instead of off button: https://github.com/flutter/flutter/issues/19783 onTapCancel: () => setState(() => _isPressed = false), child: widget.child, ),