firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Load stocks data off the network

Browse Source 
Instead of hard-coding the stock data in the Dart file, this CL moves the data
to a JSON file and loads that file over the network. This change improves load
time for the Stocks app from 3 seconds to 2 seconds.

Also, this CL removes shake-to-reload from the Stocks app because that also
slows down load time (due to the two module systems fighting each other).

R=rafaelw@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/1021723005
This commit is contained in:
Adam Barth 2015-03-23 09:59:50 -07:00
parent 03a2006046
commit cc1c9cb9fc
4 changed files with 2988 additions and 2971 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
examples/stocks-fn/lib/stock_app.dart
View File

@ -33,14 +33,18 @@ class StocksApp extends App {
${typography.white.title};''' ${typography.white.title};'''
); );
List<Stock> _sortedStocks; List<Stock> _sortedStocks = [];
bool _isSearching = false; bool _isSearching = false;
bool _isShowingMenu = false; bool _isShowingMenu = false;
String _searchQuery; String _searchQuery;
StocksApp() : super() { StocksApp() : super() {
_sortedStocks = oracle.stocks; fetchStockOracle().then((oracle) {
_sortedStocks.sort((a, b) => a.symbol.compareTo(b.symbol)); setState(() {
_sortedStocks = oracle.stocks;
_sortedStocks.sort((a, b) => a.symbol.compareTo(b.symbol));
});
});
} }
void _handleSearchClick(_) { void _handleSearchClick(_) {

2983
examples/stocks-fn/lib/stock_data.dart
View File

File diff suppressed because it is too large Load Diff

2965
examples/stocks-fn/lib/stock_data.json Normal file
View File

File diff suppressed because it is too large Load Diff

1
examples/stocks-fn/main.sky
View File

@ -5,7 +5,6 @@
// found in the LICENSE file. // found in the LICENSE file.
--> -->
<sky> <sky>
<import src="/sky/framework/debug/shake-to-reload.sky" />
<script> <script>
// TODO(abarth): Should this be package:stocks/stocks_app.dart? // TODO(abarth): Should this be package:stocks/stocks_app.dart?
import 'lib/stock_app.dart'; import 'lib/stock_app.dart';