firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

unnecessary statements (#12189)

Browse Source
This commit is contained in:
Alexandre Ardhuin 2017-09-21 08:33:56 +02:00 committed by GitHub
parent f9e8da6d32
commit cde6b669b3
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dev/bots/test.dart
View File

@ -263,7 +263,6 @@ Future<Null> _verifyNoBadImports(String workingDirectory) async {
final String libPath = path.join(workingDirectory, 'packages', 'flutter', 'lib'); final String libPath = path.join(workingDirectory, 'packages', 'flutter', 'lib');
final String srcPath = path.join(workingDirectory, 'packages', 'flutter', 'lib', 'src'); final String srcPath = path.join(workingDirectory, 'packages', 'flutter', 'lib', 'src');
// Verify there's one libPath/*.dart for each srcPath/*/. // Verify there's one libPath/*.dart for each srcPath/*/.
<String>[];
final List<String> packages = new Directory(libPath).listSync() final List<String> packages = new Directory(libPath).listSync()
.where((FileSystemEntity entity) => entity is File && path.extension(entity.path) == '.dart') .where((FileSystemEntity entity) => entity is File && path.extension(entity.path) == '.dart')
.map<String>((FileSystemEntity entity) => path.basenameWithoutExtension(entity.path)) .map<String>((FileSystemEntity entity) => path.basenameWithoutExtension(entity.path))

2
packages/flutter/lib/src/rendering/image.dart
View File

@ -128,7 +128,7 @@ class RenderImage extends RenderBox {
set colorBlendMode(BlendMode value) { set colorBlendMode(BlendMode value) {
if (value == _colorBlendMode) if (value == _colorBlendMode)
return; return;
_colorBlendMode; _colorBlendMode = value;
_updateColorFilter(); _updateColorFilter();
markNeedsPaint(); markNeedsPaint();
} }

7
packages/flutter/test/rendering/image_test.dart
View File

@ -201,4 +201,11 @@ void main() {
expect(image.size.width, equals(75.0)); expect(image.size.width, equals(75.0));
expect(image.size.height, equals(75.0)); expect(image.size.height, equals(75.0));
}); });
test('update image colorBlendMode', () {
final RenderImage image = new RenderImage();
expect(image.colorBlendMode, isNull);
image.colorBlendMode = BlendMode.color;
expect(image.colorBlendMode, BlendMode.color);
});
} }